Tabs that crash in the background fail to restore with SHIP
Categories
(Firefox :: Session Restore, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: u608768, Assigned: peterv)
References
Details
Attachments
(2 files)
STR
- Open two tabs. Note the PID of one of the tabs, and select the other.
- Kill that first process and select its corresponding tab. You should see an about:blank document, instead of about:tabcrashed.
This is causing browser/components/sessionstore/test/browser_background_tab_crash.js to fail.
Putting this in M6c because the pre-crash tab can still be manually restored with the back button, but this should be fixed sooner rather than later.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Comment 2•4 years ago
|
||
JS stack for about:tabcrashed:
(rr) js
0 sendToTabCrashedPage(browser = "[object XULFrameElement]") ["resource:///modules/ContentCrashHandlers.jsm":365:21]
this = [object Object]
1 willShowCrashedTab(browser = "[object XULFrameElement]") ["resource:///modules/ContentCrashHandlers.jsm":312:13]
this = [object Object]
2 ssi_onTabSelect(aWindow = "[object Window]") ["resource:///modules/sessionstore/SessionStore.jsm":2846:28]
this = [object Object]
3 ssi_handleEvent(aEvent = "[object CustomEvent]") ["resource:///modules/sessionstore/SessionStore.jsm":1582:13]
this = [object Object]
4 updateCurrentBrowser() ["chrome://browser/content/tabbrowser.js":1164:15]
this = [object Object]
5 _setupEventListeners/<(event = "[object Event]") ["chrome://browser/content/tabbrowser.js":5255:15]
6 set selectedIndex(val = "0") ["chrome://global/content/elements/tabbox.js":197:13]
this = [object XULElement]
7 set selectedPanel(val = "[object XULElement]") ["chrome://global/content/elements/tabbox.js":216:6]
this = [object XULElement]
8 set selectedIndex(val = "3") ["chrome://global/content/elements/tabbox.js":545:10]
this = [object XULElement]
9 set selectedItem(val = "[object XULElement]") ["chrome://global/content/elements/tabbox.js":565:34]
this = [object XULElement]
10 _selectNewTab(aNewTab = "[object XULElement]", aFallbackDir = "undefined", aWrap = "undefined") ["chrome://global/content/elements/tabbox.js":735:6]
this = [object XULElement]
11 _selectNewTab(aNewTab = "[object XULElement]") ["chrome://browser/content/tabbrowser-tabs.js":952:14]
this = [object XULElement]
12 on_mousedown(event = "[object MouseEvent]") ["chrome://global/content/elements/tabbox.js":331:27]
this = [object XULElement]
13 on_mousedown(event = "[object MouseEvent]") ["chrome://browser/content/tabbrowser-tab.js":365:14]
this = [object XULElement]
14 handleEvent(event = "[object MouseEvent]") ["chrome://global/content/customElements.js":466:26]
this = [object XULElement]
js stack for about:blank:
0 kickOffNewLoadFromBlankPage(webNavigation = "[xpconnect wrapped (nsISupports, nsIDocShell, nsILoadContext, nsIWebNavigation, nsIDocShellTreeItem, nsIWebProgress, nsIInterfaceRequestor)]", newURI = ""about:blank"") ["resource:///modules/sessionstore/ContentRestore.jsm":122:16]
1 restoreOnNewEntry(newURI = ""about:blank"") ["resource:///modules/sessionstore/ContentRestore.jsm":223:31]
this = [object Object]
2 restoreOnNewEntry(""about:blank"") ["self-hosted":1176:0]
this = [object Object]
3 receiveMessage((destructured parameter) = "[object Object]") ["resource:///modules/sessionstore/ContentSessionStore.jsm":573:28]
this = [object Object]
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/786694e7b805 Replace nsFrameLoader::mIsTopLevelContent with mPendingBrowsingContext->IsTopContent(). r=smaug https://hg.mozilla.org/integration/autoland/rev/49b550ad8387 Tabs that crash in the background fail to restore with SHIP. r=smaug
|
||
Comment 6•4 years ago
|
||
Backed out for perma failures.
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318335058&repo=autoland&lineNumber=2632
Backout: https://hg.mozilla.org/integration/autoland/rev/e70e148bcc2634fa1d5f4126e73cf8b90b67f9dd
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d98bf7b930f Replace nsFrameLoader::mIsTopLevelContent with mPendingBrowsingContext->IsTopContent(). r=smaug https://hg.mozilla.org/integration/autoland/rev/c025fad53568 Tabs that crash in the background fail to restore with SHIP. r=smaug
|
||
Comment 8•4 years ago
•
|
||
Backed out 2 changesets (Bug 1668940) for causing bc failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/19a46b1ac5db0a7946d6e5de939b754372a1187f
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=bc&tochange=19a46b1ac5db0a7946d6e5de939b754372a1187f
Failure logs:
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318380749&repo=autoland&lineNumber=2857
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318381529&repo=autoland&lineNumber=2013
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318379157&repo=autoland&lineNumber=2848
- Mochitest Plain: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318383749&repo=autoland&lineNumber=4194
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60a63cffd36b Replace nsFrameLoader::mIsTopLevelContent with mPendingBrowsingContext->IsTopContent(). r=smaug https://hg.mozilla.org/integration/autoland/rev/28453f1c1ee8 Tabs that crash in the background fail to restore with SHIP. r=smaug
|
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/60a63cffd36b
https://hg.mozilla.org/mozilla-central/rev/28453f1c1ee8
|
|
||
Updated•4 years ago
|
Description
•