Closed
Bug 1668966
Opened 4 years ago
Closed 4 years ago
only clear PresShell::mResolutionUpdated after the apz transaction
Categories
(Core :: Panning and Zooming, defect)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
We clear PresShell::mResolutionUpdated in nsLayoutUtils::ComputeScrollMetadata here
but that is incorrect because we call ComputeScrollMetadata twice for one transaction with webrender. This is why ScrollFrameHelper::NotifyApzTransaction exists: to clear things on the layout side after they are sent to the compositor.
|
Assignee | |
Comment 1•4 years ago
|
||
This causes (at least) the test for bug 1656689 to fail with webrender.
|
|
Assignee | |
Comment 2•4 years ago
|
||
We clear PresShell::mResolutionUpdated in nsLayoutUtils::ComputeScrollMetadata here
but that is incorrect because we call ComputeScrollMetadata twice for one transaction with webrender. This is why ScrollFrameHelper::NotifyApzTransaction exists: to clear things on the layout side after they are sent to the compositor.
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5380e007a12c Only clear PresShell::mResolutionUpdated after the apz transaction. r=kats,botond
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•