Closed Bug 1668966 Opened 2 months ago Closed 2 months ago

only clear PresShell::mResolutionUpdated after the apz transaction

Categories

(Core :: Panning and Zooming, defect)

defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

We clear PresShell::mResolutionUpdated in nsLayoutUtils::ComputeScrollMetadata here

https://searchfox.org/mozilla-central/rev/7ef5cefd0468b8f509efe38e0212de2398f4c8b3/layout/base/nsLayoutUtils.cpp#9419

but that is incorrect because we call ComputeScrollMetadata twice for one transaction with webrender. This is why ScrollFrameHelper::NotifyApzTransaction exists: to clear things on the layout side after they are sent to the compositor.

This causes (at least) the test for bug 1656689 to fail with webrender.

We clear PresShell::mResolutionUpdated in nsLayoutUtils::ComputeScrollMetadata here

https://searchfox.org/mozilla-central/rev/7ef5cefd0468b8f509efe38e0212de2398f4c8b3/layout/base/nsLayoutUtils.cpp#9419

but that is incorrect because we call ComputeScrollMetadata twice for one transaction with webrender. This is why ScrollFrameHelper::NotifyApzTransaction exists: to clear things on the layout side after they are sent to the compositor.

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5380e007a12c
Only clear PresShell::mResolutionUpdated after the apz transaction. r=kats,botond
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.