1669055 - Vendor Cranelift to get validate-while-parsing support

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Chris Fallin [:cfallin]]

We need to vendor in a version of Cranelift that contains PR #2059 ("Validate modules while translating"), as well as an update to the wasmparser dependency to version 0.63. This will enable us to land our patch that uses this new validation functionality.

Comment 1

[Chris Fallin [:cfallin]]

Attachment: Bug 1669055: Vendor Cranelift e22e2c3722f2fbccd3c8d3230119fa04c332c69c. r=jseward

This patch pulls in an updated Cranelift with a new validation strategy,
introduced by bytecodealliance/wasmtime#2059. This new design validates
the Wasm module as it parses the function bodies. A subsequent patch
will adapt Baldrdash to work with this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34fddbf97cc7
Vendor Cranelift e22e2c3722f2fbccd3c8d3230119fa04c332c69c. r=jseward

Comment 3

[Atila Butkovits]

Backed out for bustages complaining about rust.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a75308c509e68f885eab63bed13c5d388fb80e8f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Po30xvMfRauSX4AZ6QggUQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=34fddbf97cc7adc4fbc6feb379d027b0b94cbe44

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317798763&repo=autoland&lineNumber=33844

Comment 4

[Chris Fallin [:cfallin]]

Discussed backout with :abutkovits on Matrix; this vendoring patch was not landed atomically with the SpiderMonkey patch. Retrying the landing now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb5e11920e1a
Vendor Cranelift e22e2c3722f2fbccd3c8d3230119fa04c332c69c. r=jseward

Comment 6

[Razvan Maries]

Backed out for build bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=0807415f1ea5bf7d74ff3390b6eca7c7532cfb63&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317848026&repo=autoland&lineNumber=4852
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317848044&repo=autoland&lineNumber=45746

Valgrind bustage: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317857417&repo=autoland&lineNumber=33542

Backout: https://hg.mozilla.org/integration/autoland/rev/3792ecb5de48935bf0f7ebbdc7eaefb56e8c769c

Comment 7

[Chris Fallin [:cfallin]]

This is a warnings-as-errors failure (sorry about that!); using :bbouvier's patch from bug 1655042, here's a try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3a0b7f8294166a1ee1865753e1e33a05ea77099

I'll retry landing if/when that's green.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad2fc501557e
Vendor Cranelift e22e2c3722f2fbccd3c8d3230119fa04c332c69c. r=jseward

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ad2fc501557e