1669114 - Intermittent devtools/client/framework/test/browser_toolbox_options_disable_js.js | A promise chain failed to handle a rejection: can't access property "get", this._containers is null - stack: getContainer@resource://devtools/client/inspector/markup/marku

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=317545449&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/eD_Gs2uZR_muNHitmAXsEQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-10-04T20:21:40.382Z] 20:21:40     INFO - TEST-START | devtools/client/framework/test/browser_toolbox_options_disable_js.js
[task 2020-10-04T20:21:40.786Z] 20:21:40     INFO - GECKO(2424) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2020-10-04T20:21:40.822Z] 20:21:40     INFO - GECKO(2424) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2020-10-04T20:21:40.868Z] 20:21:40     INFO - GECKO(2424) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2020-10-04T20:21:40.909Z] 20:21:40     INFO - GECKO(2424) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2020-10-04T20:21:40.911Z] 20:21:40     INFO - GECKO(2424) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2020-10-04T20:21:40.911Z] 20:21:40     INFO - GECKO(2424) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2020-10-04T20:21:41.193Z] 20:21:41     INFO - GECKO(2424) | console.error: (new TypeError("can't access property \"button\", this.nodeHierarchy[this.currentIndex] is undefined", "resource://devtools/client/inspector/breadcrumbs.js", 805))
[task 2020-10-04T20:21:41.266Z] 20:21:41     INFO - GECKO(2424) | JavaScript error: resource://devtools/client/inspector/markup/markup.js, line 742: TypeError: can't access property "get", this._containers is null
[task 2020-10-04T20:21:42.377Z] 20:21:42     INFO - TEST-INFO | started process screencapture
[task 2020-10-04T20:21:42.512Z] 20:21:42     INFO - TEST-INFO | screencapture: exit 0
[task 2020-10-04T20:21:42.512Z] 20:21:42     INFO - Buffered messages logged at 20:21:40
[task 2020-10-04T20:21:42.513Z] 20:21:42     INFO - Entering test bound 
[task 2020-10-04T20:21:42.513Z] 20:21:42     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/framework/test/browser_toolbox_options_disable_js.html
[task 2020-10-04T20:21:42.515Z] 20:21:42     INFO - Tab added and finished loading
[task 2020-10-04T20:21:42.515Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | Toolbox selected via selectTool method - 
[task 2020-10-04T20:21:42.515Z] 20:21:42     INFO - Testing that JS is enabled
[task 2020-10-04T20:21:42.516Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | Output is "JavaScript Enabled" - "JavaScript Enabled" == "JavaScript Enabled" - 
[task 2020-10-04T20:21:42.516Z] 20:21:42     INFO - Testing that JS is enabled in the iframe
[task 2020-10-04T20:21:42.516Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | Output is "JavaScript Enabled" in iframe - "JavaScript Enabled" == "JavaScript Enabled" - 
[task 2020-10-04T20:21:42.516Z] 20:21:42     INFO - Checking checkbox to disable JS
[task 2020-10-04T20:21:42.516Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | BrowsingContextTargetFront's configureOptions is correct before the toggle - 
[task 2020-10-04T20:21:42.518Z] 20:21:42     INFO - Buffered messages logged at 20:21:41
[task 2020-10-04T20:21:42.518Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | BrowsingContextTargetFront's configureOptions is correctly updated - 
[task 2020-10-04T20:21:42.519Z] 20:21:42     INFO - Testing that JS is disabled
[task 2020-10-04T20:21:42.519Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | output is not "JavaScript Disabled" - true == true - 
[task 2020-10-04T20:21:42.519Z] 20:21:42     INFO - Testing that JS is disabled in the iframe
[task 2020-10-04T20:21:42.519Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | output is not "JavaScript Disabled" in iframe - true == true - 
[task 2020-10-04T20:21:42.519Z] 20:21:42     INFO - Clearing checkbox to re-enable JS
[task 2020-10-04T20:21:42.523Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | BrowsingContextTargetFront's configureOptions is correct before the toggle - 
[task 2020-10-04T20:21:42.524Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | BrowsingContextTargetFront's configureOptions is correctly updated - 
[task 2020-10-04T20:21:42.524Z] 20:21:42     INFO - Testing that JS is enabled
[task 2020-10-04T20:21:42.524Z] 20:21:42     INFO - Console message: [JavaScript Error: "TypeError: can't access property "get", this._containers is null" {file: "resource://devtools/client/inspector/markup/markup.js" line: 742}]
[task 2020-10-04T20:21:42.524Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | Output is "JavaScript Enabled" - "JavaScript Enabled" == "JavaScript Enabled" - 
[task 2020-10-04T20:21:42.525Z] 20:21:42     INFO - Testing that JS is enabled in the iframe
[task 2020-10-04T20:21:42.525Z] 20:21:42     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_options_disable_js.js | Output is "JavaScript Enabled" in iframe - "JavaScript Enabled" == "JavaScript Enabled" - 
[task 2020-10-04T20:21:42.525Z] 20:21:42     INFO - Buffered messages finished
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_options_disable_js.js | A promise chain failed to handle a rejection: can't access property "get", this._containers is null - stack: getContainer@resource://devtools/client/inspector/markup/markup.js:742:5
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - _onResourceAvailable@resource://devtools/client/inspector/markup/markup.js:1390:30
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - _notifyWatchers@resource://devtools/shared/resources/resource-watcher.js:557:24
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - throttle/<@resource://devtools/shared/throttle.js:45:21
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - _onResourceAvailable@resource://devtools/shared/resources/resource-watcher.js:370:10
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - module.exports/<@resource://devtools/shared/resources/legacy-listeners/root-node.js:54:12
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - _emit@resource://devtools/shared/event-emitter.js:226:34
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - emit@resource://devtools/shared/event-emitter.js:172:18
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - emit@resource://devtools/shared/event-emitter.js:324:18
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - onPacket@resource://devtools/shared/protocol/Front.js:312:13
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - onPacket@resource://devtools/client/devtools-client.js:492:13
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - send/<@resource://devtools/shared/transport/local-transport.js:68:25
[task 2020-10-04T20:21:42.526Z] 20:21:42     INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/DevToolsUtils.js:54:21
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - send@resource://devtools/shared/transport/local-transport.js:56:21
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - send@resource://devtools/server/devtools-server-connection.js:99:20
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - receiveMessage@resource://devtools/shared/transport/child-transport.js:66:16
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - MessageListener.receiveMessage*_addListener@resource://devtools/shared/transport/child-transport.js:40:14
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - ready@resource://devtools/shared/transport/child-transport.js:57:10
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - connectToFrame/</onActorCreated<@resource://devtools/server/connectors/frame-connector.js:183:22
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - MessageListener.receiveMessage*trackMessageManager@resource://devtools/server/connectors/frame-connector.js:55:12
[task 2020-10-04T20:21:42.527Z] 20:21:42     INFO - connectToFrame/<@resource://devtools/server/connectors/frame-connector.js:283:5
[task 2020-10-04T20:21:42.528Z] 20:21:42     INFO - connectToFrame@resource://devtools/server/connectors/frame-connector.js:41:10
[task 2020-10-04T20:21:42.529Z] 20:21:42     INFO - getTarget/<@resource://devtools/server/actors/descriptors/tab.js:159:35
[task 2020-10-04T20:21:42.529Z] 20:21:42     INFO - getTarget@resource://devtools/server/actors/descriptors/tab.js:143:12
[task 2020-10-04T20:21:42.529Z] 20:21:42     INFO - handler@resource://devtools/shared/protocol/Actor.js:172:37
[task 2020-10-04T20:21:42.530Z] 20:21:42     INFO - onPacket@resource://devtools/server/devtools-server-connection.js:379:58
[task 2020-10-04T20:21:42.530Z] 20:21:42     INFO - send/<@resource://devtools/shared/transport/local-transport.js:68:25
[task 2020-10-04T20:21:42.530Z] 20:21:42     INFO - exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
[task 2020-10-04T20:21:42.530Z] 20:21:42     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/DevToolsUtils.js:54:21```

Comment 1

[Intermittent Failures Robot]

1 failures in 4195 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1669114&startday=2020-09-28&endday=2020-10-04&tree=all

Comment 2

[Intermittent Failures Robot]

1 failures in 4130 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1669114&startday=2020-10-05&endday=2020-10-11&tree=all

Comment 3

[Intermittent Failures Robot]

2 failures in 3694 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• mozilla-central: 1

Platform breakdown:

• macosx1014-64-devedition: 1
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1669114&startday=2020-10-12&endday=2020-10-18&tree=all

Comment 4

[Intermittent Failures Robot]

2 failures in 4275 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• mozilla-beta: 1

Platform breakdown:

• macosx1014-64-shippable: 1
• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1669114&startday=2020-10-26&endday=2020-11-01&tree=all

Comment 5

[Intermittent Failures Robot]

2 failures in 4128 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• macosx1014-64-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1669114&startday=2020-11-02&endday=2020-11-08&tree=all

Comment 6

[Intermittent Failures Robot]

5 failures in 4040 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-central: 2

Platform breakdown:

• macosx1014-64-qr: 3
• macosx1014-64-shippable-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2020-11-09&endday=2020-11-15&tree=all

Comment 7

[Intermittent Failures Robot]

22 failures in 4810 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 12
• mozilla-central: 6
• try: 3
• mozilla-beta: 1

Platform breakdown:

• macosx1014-64-qr: 12
• macosx1014-64-shippable-qr: 6
• macosx1014-64-devedition-qr: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2020-11-16&endday=2020-11-22&tree=all

Comment 8

[Intermittent Failures Robot]

17 failures in 1479 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #35 most frequent failure this week.

Repository breakdown:

• autoland: 11
• try: 4
• mozilla-central: 1
• mozilla-beta: 1

Platform breakdown:

• macosx1014-64-qr: 11
• macosx1014-64-devedition-qr: 5
• macosx1014-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2020-11-23&endday=2020-11-29&tree=all

Comment 9

[Intermittent Failures Robot]

11 failures in 3712 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8
• mozilla-central: 2
• try: 1

Platform breakdown:

• macosx1014-64-qr: 8
• macosx1014-64-shippable-qr: 2
• macosx1014-64-devedition-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2020-11-30&endday=2020-12-06&tree=all

Comment 10

[Intermittent Failures Robot]

20 failures in 4060 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 14
• try: 3
• mozilla-central: 3

Platform breakdown:

• macosx1014-64-qr: 14
• macosx1014-64-devedition-qr: 3
• macosx1014-64-shippable-qr: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2020-12-07&endday=2020-12-13&tree=all

Comment 11

[Intermittent Failures Robot]

17 failures in 3421 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 3
• mozilla-central: 7
• autoland: 6
• try: 1

Platform breakdown:

• macosx1014-64-devedition-qr: 4
• macosx1014-64-shippable-qr: 7
• macosx1014-64-qr: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2020-12-14&endday=2020-12-20&tree=all

Comment 12

[Intermittent Failures Robot]

14 failures in 1450 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6
• try: 4
• mozilla-beta: 2
• mozilla-central: 2

Platform breakdown:

• macosx1014-64-qr: 6
• macosx1014-64-devedition-qr: 4
• macosx1014-64-shippable-qr: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2020-12-21&endday=2020-12-27&tree=all

Comment 13

[Intermittent Failures Robot]

12 failures in 525 pushes (0.023 failures/push) were associated with this bug in the last 7 days.

This is the #41 most frequent failure this week.

Repository breakdown:

• autoland: 7
• mozilla-central: 5

Platform breakdown:

• macosx1014-64-qr: 7
• macosx1014-64-shippable-qr: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2020-12-28&endday=2021-01-03&tree=all

Comment 14

[Intermittent Failures Robot]

17 failures in 2956 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9
• mozilla-central: 3
• mozilla-beta: 3
• try: 2

Platform breakdown:

• macosx1014-64-qr: 9
• macosx1014-64-shippable-qr: 3
• macosx1014-64-devedition-qr: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2021-01-04&endday=2021-01-10&tree=all

Comment 15

[Intermittent Failures Robot]

12 failures in 3810 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• try: 2
• mozilla-central: 2
• mozilla-beta: 3

Platform breakdown:

• macosx1014-64-qr: 5
• macosx1014-64-devedition-qr: 5
• macosx1014-64-shippable-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2021-01-11&endday=2021-01-17&tree=all

Comment 16

[Intermittent Failures Robot]

18 failures in 3488 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 14
• mozilla-central: 4

Platform and build breakdown:

• macosx1014-64-qr: 13
  • opt: 13
• macosx1014-64-shippable-qr: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2021-01-18&endday=2021-01-24&tree=all

Comment 17

[Intermittent Failures Robot]

20 failures in 3891 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6
• autoland: 10
• try: 1
• mozilla-beta: 3

Platform and build breakdown:

• macosx1014-64-shippable-qr: 6
  • opt: 6
• macosx1014-64-qr: 11
  • opt: 11
• macosx1014-64-devedition-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2021-01-25&endday=2021-01-31&tree=all

Comment 18

[Intermittent Failures Robot]

24 failures in 3966 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 11
• mozilla-beta: 7
• mozilla-central: 6

Platform and build breakdown:

• macosx1014-64-qr: 11
  • opt: 11
• macosx1014-64-devedition-qr: 7
  • opt: 7
• macosx1014-64-shippable-qr: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2021-02-01&endday=2021-02-07&tree=all

Comment 19

[Intermittent Failures Robot]

22 failures in 4322 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 5
• mozilla-central: 8
• autoland: 8
• try: 1

Platform and build breakdown:

• macosx1014-64-devedition-qr: 5
  • opt: 5
• macosx1014-64-shippable-qr: 9
  • opt: 9
• macosx1014-64-qr: 8
  • opt: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2021-02-08&endday=2021-02-14&tree=all

Comment 20

[Julian Descottes [:jdescottes]]

I think most of the browser_toolbox_options_disable_js.js intermittents are related to a race condition between the watchResources/unwatchResources calls made by the markup view.

MarkupView calls watchResources from its constructor, and unwatchResources from its destroy.
The issue is that watchResources is async, and will only populate the internal _watchers array of ResourceWatcher at the end of the method. If unwatchResource is called before watchResources could resolve then the entry will not be purged from the resourceWatcher.

In this case this means that a destroyed MarkupView instance will keep receive resource available notifications, which will fail in various ways, leading to unhandled promise rejections.

Several thoughts on how to fix this:

• the test could open on the options panel directly and not involve the inspector at all
• resource watcher could support calls to unwatchResources happening before watchResources resolved (need a new map to keep track of things but doable)
• markup view should properly wait on its watchResources call (but it wouldn't fix anything here, the inspector is just a panel loaded in the background)
• markup view should add some logic to unwatchResources only after watchResources was called

Obviously I'll go for the first option here as the others require more discussion.

Comment 21

[Julian Descottes [:jdescottes]]

Attachment: Bug 1669114 - [devtools] Do not involve the inspector in browser_toolbox_options_disable_js

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57fd0943cb50
[devtools] Do not involve the inspector in browser_toolbox_options_disable_js r=nchevobbe

Comment 23

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/57fd0943cb50

Comment 24

[Intermittent Failures Robot]

5 failures in 3737 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2
• mozilla-central: 1
• try: 2

Platform and build breakdown:

• macosx1014-64-qr: 2
  • opt: 2
• macosx1014-64-shippable-qr: 1
  • opt: 1
• macosx1014-64-devedition-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1669114&startday=2021-02-15&endday=2021-02-21&tree=all