166917 - Clean up SDK includes

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

I want to do at least the following:

Remove obsolete #includes from required XPCOM headers.
Export all glue headers into the SDK directory.
Push nsError.h into the SDK.  (eg freeze the defines in that file)

Comment 1

[Doug Turner (:dougt)]

Attachment: proposed patch

zip attachment.  544kb.  most of the patch is a global search and replaces from
NS_INIT_REFCNT to NS_INIT_ISUPPORTS.

This does a few things:

converts NS_INIT_REFCNT() to NS_INIT_ISUPPORTS()

removes includes of "nsComObsolete.h" and "nsISupportsObsolete.h" from xpcom
public includes.  (and sprinkles some #includes where needed)

makes all of the xpcom glue headers be exported into the sdk directory.  

makes nsError.h part of the sdk.  (this include common error codes, NS_FAILED,
NS_SUCCEEDED macros)

Comment 2

[rpotts (gone)]

Comment on attachment 98152 [details]
proposed patch

sr=[e-mail].

ignoring changes to makefiles in c-sdk and the changes to nsAppRunner.cpp

Comment 3

[Alec Flett]

r=alecf

Comment 4

[Alec Flett]

Comment on attachment 98152 [details]
proposed patch

oops, r=alecf

This looks very mechanical, I spent a few minutes taking random samples from
the patch.. they all looked fine.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 98152 [details]
proposed patch

a=[e-mail]

Comment 6

[Doug Turner (:dougt)]

Thanks.

Landing now.

Comment 7

[Doug Turner (:dougt)]

mirrors were busted and the tree was closed - i couldn't land.  Try again later.

Comment 8

[Doug Turner (:dougt)]

landed.