1669175 - Crash in [@ std::_Func_impl_no_alloc<T>::_Do_call | mozilla::dom::BrowsingContext::PreOrderWalk]

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Julien Cristau [:jcristau]]

Crash report: https://crash-stats.mozilla.org/report/index/54135559-518b-4b1c-b941-48fdb0201004

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll std::_Func_impl_no_alloc<`lambda at /builds/worker/checkouts/gecko/dom/ipc/ContentChild.cpp:4236:29', void, mozilla::dom::BrowsingContext*>::_Do_call 
1 xul.dll mozilla::dom::BrowsingContext::PreOrderWalk docshell/base/BrowsingContext.cpp:849
2 xul.dll mozilla::dom::BrowsingContext::PreOrderWalk docshell/base/BrowsingContext.cpp:855
3 xul.dll static mozilla::dom::ContentChild::DispatchBeforeUnloadToSubtree dom/ipc/ContentChild.cpp:4236
4 xul.dll mozilla::dom::ContentChild::RecvDispatchBeforeUnloadToSubtree dom/ipc/ContentChild.cpp:4226
5 xul.dll mozilla::dom::PContentChild::OnMessageReceived ipc/ipdl/PContentChild.cpp:13687
6 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2074
7 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1953
8 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:514
9 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1234

Seeing more crashes at null even after the fix for bug 1667491

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1669175: Fix another null deref in beforeunload code. r=nika

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83ba33f74ad8
Fix another null deref in beforeunload code. r=nika

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/83ba33f74ad8