1669188 - The print shortcut is wrongly displayed when the `print.tab_modal.enabled` pref is set to false until the Firefox menu is displayed a second time

Status: VERIFIED FIXED

(Toolkit :: Printing, defect)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA, OOO until the 3rd of Jul needinfo @mcoman or @poiegas]

Attachment: shortcut string dissappearing.gif

[Affected versions]:

• Firefox Nightly 83.0a1, Build ID 20201004212809
• Firefox Beta 82.0b7, BuildID 20201002191150

[Affected Platforms]:

• Windows 10
• Ubuntu 20.04

[Prerequisites]:

• Have the print.tab_modal.enabled set to false.

[Steps to reproduce]:

1. Open a new Firefox Beta profile.
2. Click the Firefox Menu button and observe the Print... option.
3. Dismiss the doorhanger by clicking in the current page.
4. Click the Firefox Menu button and observe the Print... option.

[Expected results]:

• No shortcut string is displayed next to the option.

[Actual results]:

• The shortcut string is displayed at Step 2 and it is no longer displayed at Step 4.

[Notes]:

• The issue is not reproducible on Firefox Release 81.0.
• The issue is not reproducible on macOS.
• Attached a screen recording of the issue.

Comment 1

[:Gijs (he/him)]

Emma, do you know what's going on here? I looked briefly but I'm a bit puzzled. The shortcut attribute is being removed, but I don't understand why.

Comment 2

[Emma Malysz]

I was able to reproduce this on version 81.0.1, so I went ahead and changed the flag.

I'll go ahead and take a closer look at this.

Comment 3

[Emma Malysz]

Attachment: Bug 1669188, hide shortcut if print.tab_modal.enabled is false

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8963c3923ebd
hide shortcut if print.tab_modal.enabled is false r=Gijs

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8963c3923ebd

Comment 6

[Emma Malysz]

Comment on attachment 9179765 [details]
Bug 1669188, hide shortcut if print.tab_modal.enabled is false

Beta/Release Uplift Approval Request

• User impact if declined: This regresses the old UI for the shortcuts. This is low impact compared to other uplifts, so if it causes any problems, I can cancel this request
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Windows:

1. Open firefox with print.tab_modal.enabled set to false
2. Open main hamburger menu
3. Notice shortcut is not present
4. close panel
5. Open again and notice shortcut is still missing

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No string changes, but this is a change that has impacted a few release cycles
• String changes made/needed: n/a

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9179765 [details]
Bug 1669188, hide shortcut if print.tab_modal.enabled is false

I'm going to call this wontfix for 82 since this is kind of polishy and was around in 81 already

Comment 8

[Ciprian Muresan [:cmuresan], Ecosystem QA, OOO until the 3rd of Jul needinfo @mcoman or @poiegas]

I have verified that the issue is no longer reproducible in the latest Nightly 83.0a1 (BuildID 20201008210150) using Windows and LinuxMX 4.19.