1669203 - MaybeRenewHostRecord should hold the resolver lock.

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

The eviction queue is accessed on multiple threads so we should avoid data races.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1669203 - MaybeRenewHostRecord should hold the resolver lock. r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10fd134507a8
MaybeRenewHostRecord should hold the resolver lock. r=necko-reviewers,kershaw

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/10fd134507a8

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9179584 [details]
Bug 1669203 - MaybeRenewHostRecord should hold the resolver lock. r=#necko

Beta/Release Uplift Approval Request

• User impact if declined: Potential data races when parsing HTTPS records with TRR enabled (bug 1652670)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This issue has been identified through code inspection. HTTPS records aren't very common yet but it would be good to make sure they don't cause a crash or worse on 82.
  We just make sure to hold a lock when removing elements from the linked list.
• String changes made/needed:

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9179584 [details]
Bug 1669203 - MaybeRenewHostRecord should hold the resolver lock. r=#necko

given how late we are in the cycle I'd rather let this ride the trains