Closed Bug 1669297 Opened 4 years ago Closed 4 years ago

Update Bing logo to new icon (and possibly name)

Categories

(Firefox :: Search, task, P2)

task
Points:
2

Tracking

()

VERIFIED FIXED
85 Branch
Iteration:
85.2 - Nov 30 - Dec 13
Tracking Status
firefox-esr78 --- verified
firefox85 --- verified

People

(Reporter: mkaply, Assigned: standard8)

References

Details

Attachments

(5 files)

Bing released a new logo and renamed Bing to Microsoft Bing:

https://www.theverge.com/2020/10/5/21502315/microsoft-bing-rebrand-search-engine-logo

We should update to the new logo and decide if the name change is necessary.

Changing the name is currently likely to loose the user's settings relating to Bing. Unfortunately we still index on name.

We could hacker-de-hack it in the UI...

Assignee: nobody → standard8
Severity: -- → N/A
Iteration: --- → 85.1 - Nov 16 - Nov 29
Points: --- → 2
Priority: -- → P2

Mike & I looked at Bing's logo standards and we believe the name is ok as it currently is.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfdf69fc9e42 Update Bing's logo for the search engine. r=mkaply.
Iteration: 85.1 - Nov 16 - Nov 29 → 85.2 - Nov 30 - Dec 13
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

Verified on Windows 10, macOS 10.12 and Ubuntu 18.04 using the latest Fx85.0a1.

Verified multiple points where the bing logo is displayed:

  • URL bar
  • enabled search bar
  • websearch bar
  • default search engine drop-down
  • search shortcut section (removed and re-added to verify nothing broke)
Status: RESOLVED → VERIFIED

Comment on attachment 9189184 [details]
Bug 1669297 - Update Bing's logo for the search engine. r?mkaply!.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Branding issue with Bing
  • User impact if declined: Wrong bing logo
  • Fix Landed on Version: 85
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just an icon change
  • String or UUID changes made by this patch:
Attachment #9189184 - Flags: approval-mozilla-esr78?

Comment on attachment 9189184 [details]
Bug 1669297 - Update Bing's logo for the search engine. r?mkaply!.

Approved for 78.7esr.

Attachment #9189184 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
Attached image bing addon.png

Hi,

I downloaded the Beta ES-Ar version, and for Argentina bing is not a default search engine. So I added it manually. The addon had the new icon but the one-off did not have the new icon. You can also see that the icon of the addon is right on the upper right corner.

Flags: needinfo?(standard8)
Attached image Snag_b92d00a.png

It also has the old icon on about:preferences#search

The Bing add-on points to https://www.bing.com/favicon.ico as the icon to use for their search engine definition. We don't have any control over their add-on, that is separate to the application defined engine.

To test this, you need to use a locale/region where Bing is defined by Firefox.

Flags: needinfo?(standard8)
Attached image esr

Hi Mark, sorry for answering so late, I forgot to add myself to cc so I didn't get a notification when you answered.

So I tested this on the esr en-us build and I still see the old logo. Could you check, please?

Thanks, Flor.

Flags: needinfo?(standard8)

According to comment 10, I think you need 78.7esr - that looks like 78.6.1esr.

Flags: needinfo?(standard8)

Oh thanks for the tip. So 78.7 isn't available yet, so I'll test this again in about 3 weeks.

Attached image top sites

Hi Mark, so I tested this on esr 78.7, it looks good except that the topsite icon is showing the old one. This also happens on Nightly. I didn't check beta or release. Is this a bug on our side or is bing sending the wrong picture?
Thanks, Flor.

Flags: needinfo?(standard8)
See Also: → 1688088

Thanks for pointing that out - we missed it (it is wrong in central as well). I've filed bug 1688088 to fix that.

Flags: needinfo?(standard8)

You're welcome. Since there's a new bug for topsites, I'll mark esr as verified.
Thanks Mark for all of the responses.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: