1669306 - jsapi-tests subtests have very high overhead

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Steve Fink [:sfink] [:s:]]

I was looking at nbp's JIT ABI test. It generates a large number of subtests (sorry, this terminology doesn't really match the code). Each subtest creates a new context/runtime and global, then shuts it down at the end. The whole test takes about 2.5 minutes to run on my machine. If I remove the overhead, it takes about 0.5 seconds (a 322x speedup!).

The overhead appears to be almost entirely from compiling the self-hosted code.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1669306 - Allow JSAPI tests to opt-in to reuse a global and cx instead of tearing everything down and starting up every time.

Cons: (1) messy, (2) may be unnecessary once Stencil allows better caching of self-hosted code.

Pros: 322x faster for testJitABIcalls.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52f41e8893b6
Allow JSAPI tests to opt-in to reuse a global and cx instead of tearing everything down and starting up every time. r=nbp

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 52f41e8893b6 (Bug 1669306) for causing failures in RootingAPI.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/6d691612e4539f0376841789c11a35b0211f4b02

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=6d691612e4539f0376841789c11a35b0211f4b02&fromchange=52f41e8893b6e74f916687358064486643b87b86&selectedTaskRun=MotAnf3URJyTyfjclFK_Aw.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318491553&repo=autoland&lineNumber=7450

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43f3f2c3c5ed
Allow JSAPI tests to opt-in to reuse a global and cx instead of tearing everything down and starting up every time. r=nbp

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/43f3f2c3c5ed