1669353 - Stop using ProcessDescriptor.getTarget / process target from about:debugging

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement)

Description

[Alexandre Poirot [:ochameau]]

While looking into bug 1620248, I was wondering if we were still trying to instantiate process targets outside of the legacy listeners.
We do, at least from about:debugging, over here:
https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging/src/actions/debug-targets.js#263
but this isn't really justified. We probably tweaked this code a couple of time when migration to descriptors.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1669353 - [devtools] Remove unused processId attribute from about:debugging on process targets.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1669353 - [devtools] Stop instantiating main process target front from about:debugging.

We can let about:devtools-toolbox instantiate it, as we do for most other target types.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1669353 - [devtools] Tweak about:debugging main process test to check no target is created

Depends on D92499
Tweak an existing mock in the main process about:debugging test to check that we are not creating any target.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7952069faaaf
[devtools] Remove unused processId attribute from about:debugging on process targets. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/3281394da09e
[devtools] Stop instantiating main process target front from about:debugging. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/ff1750ffbc4d
[devtools] Tweak about:debugging main process test to check no target is created r=ochameau

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7952069faaaf
https://hg.mozilla.org/mozilla-central/rev/3281394da09e
https://hg.mozilla.org/mozilla-central/rev/ff1750ffbc4d