1669435 - Also run Puppeteer unit tests in headful mode in CI

Status: NEW

(Remote Protocol :: Agent, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

By default we run all the tests in non-headless mode in CI. But pup jobs are only run in headless mode. So should add a job that runs in non-headless.

Preferable we should wait until we run by changeset on trunk as getting added by bug 1628589.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When we want to announce Puppeteer compatibility with Firefox for WebDriver BiDi we probably should have the tests also running in headful mode. Maybe something we can target for early M9 if needed?

Comment 2

[Julian Descottes [:jdescottes]]

Discussed in triage, let's move it to the backlog

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Julian Descottes [:jdescottes] from comment #2)

Discussed in triage, let's move it to the backlog

What exactly has been discussed during triage? Shall we add this job to reach the Puppeteer compatibility or aren't we interested in headful tests right now and keep it as P3? That's not clear to me. Julian, maybe you can clarify? Thanks.

Comment 4

[Julian Descottes [:jdescottes]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #3)

(In reply to Julian Descottes [:jdescottes] from comment #2)

Discussed in triage, let's move it to the backlog

What exactly has been discussed during triage? Shall we add this job to reach the Puppeteer compatibility or aren't we interested in headful tests right now and keep it as P3? That's not clear to me. Julian, maybe you can clarify? Thanks.

It's backlog P3 S3, so it's nice to have but not a priority.
The reasoning is that it's more important to work on actual features or bug fixes which enable Puppeteer to work with BiDi.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Joel, given that you work a lot with CI configuration do you have an idea how hard it would be to get a source test running in headful mode? Do we already have some other source tests jobs that do that? Or would our Puppeteer job be the first consumer of such a mode? Thanks.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

the puppeteer jobs would be the first, but the docker image is the same for linux and the windows vm is the same on windows. source test is just a pool configured differently (disk, memory, etc.)