Closed Bug 1669447 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26007 - Revert "[LayoutNG] Don't truncate margins after spanners."

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26007 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26007
Details from upstream follow.

b'Nohemi Fernandez <fernandex@chromium.org>' wrote:

Revert "[LayoutNG] Don't truncate margins after spanners."

This reverts commit 430b7621a298f2744248997692a2d8f68224fa67.

Reason for revert: Failing builder https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel

Original change's description:

[LayoutNG] Don't truncate margins after spanners.

A column spanner forcefully breaks a column, so any leading margins on
content right after the spanner shouldn't be discarded.

Bug: 829028
Change-Id: I767466677d72be2760306ddd531e847f52cfa8ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445482
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813892}

TBR=ikilpatrick@chromium.org,mstensho@chromium.org,almaher@microsoft.com

Change-Id: I535ec21071aacd85f22968286e0f920fd2870324
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450062
Reviewed-by: Nohemi Fernandez \<fernandex@chromium.org>
Commit-Queue: Nohemi Fernandez \<fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814142}

PR 26007 applied with additional changes from upstream: f26f2afa7190bd5996071f56fdc5557c4828a695
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04526edadb4b
[wpt PR 26007] - Revert "[LayoutNG] Don't truncate margins after spanners.", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.