1669453 - history.replace/pushState should throw SECURITY_ERR, not NS_ERROR_FAILURE with cross-origin urls

Status: NEW

(Core :: DOM: Navigation, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

the-history-interface/001.html
and
the-history-interface/002.html
seem to test this

Comment 1

[Chris Peterson [:cpeterson]]

Olli, do these test failures affect both Fission and non-Fission?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yes. This isn't a Fission bug.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Olli Pettay [:smaug] from comment #2)

This isn't a Fission bug.

In that case, clearing the Fission Milestone flag and leaving Priority/Severity unchanged at P3/S4.

Comment 4

[dvedvick]

Attachment: Bug 1669453 - Reject about:blank and data URIs in AddState with SECURITY_ERR. r?smaug

Comment 5

[dvedvick]

Hello, I've submitted a patch for this change. Hopefully it fits the bill!

Comment 6

[dvedvick]

Attachment: WIP: Bug 1669453 - Remove excluded tests

Comment 7

[dvedvick]

Attachment: Bug 1669453 - Get user passwords after validating same-origin. r?smaug

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1313a6a0c641
Get user passwords after validating same-origin. r=smaug

Comment 9

[Cristian Tuns]

Backed out for causing wpt failures in history_pushstate_url_rewriting.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /html/browsers/history/the-history-interface/history_pushstate_url_rewriting.html | http://web-platform.test:8000/common/blank.html to about:blank should not work - expected FAIL

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/3e561c391676
Backed out changeset 1313a6a0c641 for causing wpt failures in history_pushstate_url_rewriting.html CLOSED TREE

Comment 11

[dvedvick]

I believe that it's correct for these tests to now pass due to these changes. I've updated the change to remove these tests from the expected failures.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.