1669502 - The Fission experiment doorhanger is not displayed when using Permanent Private Browsing

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: NoDoorhangerDisplayed_privateBrowsing.gif

[Affected versions]:

• Firefox Nightly 83.0a1 (Build ID: 20201006041051)

[Affected Platforms]:

• Windows 10 x64
• Mac 10.15

[Prerequisites]:

• Have the latest Firefox Nightly browser installed.
• Have a new Firefox profile.
• Have the “browser.privatebrowsing.autostart” pref set to true.
• Have the user.js for the “fission-enabled” branch downloaded to your PC.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the "about:support" page and open the profile folder.
3. Paste the user.js file from prerequisites and restart the browser.
4. Restart the browser for the second time and navigate to any website (e.g. https://www.wikipedia.org/).
5. Observe the behavior.

[Expected result]:

• The page is successfully opened and the "Fission" doorhanger displayed.

[Actual result]:

• The Fission experiment doorhanger is not displayed.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

andreio, does https://github.com/mozilla/messaging-system-inflight-assets/pull/156 somehow specify that it shouldn't be displayed in private mode?

Comment 2

[Andrei Oprea [:andreio]]

We never show any messages or notifications in private browsing mode. I think all of the design around messaging has considered PBM == distraction free.

https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/browser/components/newtab/lib/CFRPageActions.jsm#1118-1120

Comment 3

[Neha Kochar [:neha]]

Thanks Andrei. I think that's fine then. We don't necessarily need to show the Fission doorhanger in private browsing mode.