Land some patches from bug 1458653
Categories
(Core :: Panning and Zooming, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(3 files)
To avoid bitrotting patches that have already been reviewed, I'm extracting them from bug 1458653 and landing them in this bug. They do not change behavior.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
This code is unused by default because apz.android.chrome_fling_physics.enabled
defaults to true. It should probably be removed.
The comparison velocity.Length() >= StaticPrefs::apz_fling_accel_interval_ms()
was accidentally broken in bug 1560837 and is now comparing a vector length to
a value in milliseconds. This has effectively turned it into an if (false)
because velocities higher than 750 pixels per millisecond are very hard to achieve.
Until this code gets removed, this patch just makes a simplification to it
which preserves the effective (accidental) behavior, so that future patches can
change prefs as needed and don't need to maintain this unused code path.
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/9bee017548a1 Add a missing #include. r=kats https://hg.mozilla.org/integration/autoland/rev/3a225f6f47d0 Move fling acceleration logic into a new FlingAccelerator class. No functional changes. r=kats https://hg.mozilla.org/integration/autoland/rev/1a9141c07114 Simplify an unused code path. r=kats
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9bee017548a1
https://hg.mozilla.org/mozilla-central/rev/3a225f6f47d0
https://hg.mozilla.org/mozilla-central/rev/1a9141c07114
Description
•