1669592 - Cleanup devtools/client/debugger/package.json

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P2)

Description

[Alexandre Poirot [:ochameau]]

This file:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/package.json
probably contains various, now-useless (dev-)dependencies.

It would be great to review this in order to:

• speed up the execution of yarn (still needed for jest, flow and building bundled files)
• avoid pollution your local checkout (eslint fails running after having run yarn)
• reduce security threat (less npm module we load, less chance we install some uncontrolled nested dependency)

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1669592 - [devtools] Cleanup debugger/package.json.

This changeset focus on devDependencies, but a similar work can probably be done on dependencies.
Many dependencies are justifies solely because of jest.
In order to run flow, we only need flow, and we need very few things for bin/bundle.
For me, the three things to keep working are:

• flow
• jest
• bin/bundle to rebuild vendors, reps, worker modules
  The debugger frontend itself (src/ folder) is built without involving yarn/package.json.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1669592 - [devtools] Cleanup debugger/package.json dependencies list

This changeset focuses on dependencies, but surprisingly, it has an impact on bundles.
Looks like one dependency uses another revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c596aa6b35d5
[devtools] Cleanup debugger/package.json. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/d01b9d7154d2
[devtools] Cleanup debugger/package.json dependencies list r=jdescottes

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c596aa6b35d5
https://hg.mozilla.org/mozilla-central/rev/d01b9d7154d2