1669608 - Update activity-stream bundled OS specific css files

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect)

Description

[Punam Dahiya [:pdahiya]]

Running npm run bundle --prefix browser/components/newtab in latest m-c shows changes not checked in below files.

modified: browser/components/newtab/css/activity-stream-linux.css
modified: browser/components/newtab/css/activity-stream-mac.css
modified: browser/components/newtab/css/activity-stream-windows.css

It looks like fallout of https://bugzilla.mozilla.org/show_bug.cgi?id=1668401

Comment 1

[Punam Dahiya [:pdahiya]]

NI @emcminn to confirm and help fix the issue. Thanks!

Comment 2

[Emily McMinn :emcminn]

Attachment: Bug 1669608 - Bring bundled css up to date

Comment 3

[Emily McMinn :emcminn]

I see this too! The test for the bundle is in try-runner.js, so it runs in treeherder. I'm guessing because the patch was flagged testing-exception-ui those tests would not have been run.

Comment 4

[Ed Lee :Mardak]

The automation for checkBundles doesn't include css files -- only the 2 bundle.js files:
https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/browser/components/newtab/bin/try-runner.js#52-59

I suppose a separate bug would be to check the css files too.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52f9e217e665
Bring bundled css up to date r=pdahiya

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/52f9e217e665

Comment 7

[Emily McMinn :emcminn]

(In reply to Ed Lee :Mardak from comment #4)

The automation for checkBundles doesn't include css files -- only the 2 bundle.js files:
https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/browser/components/newtab/bin/try-runner.js#52-59

I suppose a separate bug would be to check the css files too.

That's a good idea, I can file something and add that check to try-runner. We would still have a loophole in the case of testing-exception-ui though, right? So to close it we may want to make sure try-runner runs during npm test too. I'm assuming we ask our contributors to run npm test and mach test before submitting :)