1669613 - Call `audio_object_{add, remove}_property_listener` outside of `assert*!`

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[C.M.Chang[:chunmin]]

In create_blank_device_sync:

assert_eq!(
    audio_object_add_property_listener(
        kAudioObjectSystemObject,
        &address,
        devices_changed_callback,
        data_ptr as *mut c_void,
    ),
    NO_ERR
);

We call audio_object_add_property_listener and audio_object_remove_property_listener inside a assert_eq!, which may not be executed in optimized build. Hence, it may cause the data racing mentioned here.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: GitHub Pull Request

Comment 2

[C.M.Chang[:chunmin]]

The patch is landed via bug 1669852.