1669639 - [Linux] PGO build failure Permission denied: '.../cp437.pyc'

Status: RESOLVED DUPLICATE of bug 1668718

(Firefox Build System :: General, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

On Fedora 33 with PGO builds I'm getting build this failure:

60:36.82 gmake: Leaving directory '/builddir/build/BUILD/firefox-81.0.1/objdir/instrumented'
Traceback (most recent call last):
File "/builddir/build/BUILD/firefox-81.0.1/testing/mozbase/mozprofile/mozprofile/addons.py", line 259, in addon_details
compressed_file = zipfile.ZipFile(addon_path, 'r')
File "/usr/lib64/python3.9/zipfile.py", line 1257, in init
self._RealGetContents()
File "/usr/lib64/python3.9/zipfile.py", line 1362, in _RealGetContents
filename = filename.decode('cp437')
File "/builddir/build/BUILD/firefox-81.0.1/objdir/instrumented/_virtualenvs/init_py3/lib64/python3.9/encodings/init.py", line 98, in search_function
mod = import('encodings.' + modname, fromlist=_import_tail,
File "/builddir/build/BUILD/firefox-81.0.1/build/mach_bootstrap.py", line 510, in call
os.remove(module.file)
PermissionError: [Errno 13] Permission denied: '/builddir/build/BUILD/firefox-81.0.1/objdir/instrumented/_virtualenvs/init_py3/lib64/python3.9/encodings/cp437.pyc'

This is because ImportHook() tries to delete:

/builddir/build/BUILD/firefox-81.0.1/objdir/instrumented/_virtualenvs/init_py3/lib64/python3.9/encodings/cp437.pyc

but that's:

/usr/lib64/python3.9/encodings/cp437.pyc

which is owned by root.

/builddir/build/BUILD/firefox-81.0.1/objdir/instrumented/_virtualenvs/init_py3/lib64/python3.9/encodings/ is a symlink to /usr/lib64/python3.9/encodings/.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: pgo-build-python.patch

There's a dump patch which ignores the error although it may be wrong.
Mike, any idea here?
Thanks.

Comment 2

[Mike Hommey [:glandium]]

I'm pretty sure this is fixed by bug 1668718.