1669655 - Cleanup worker-connector.js and startup/worker.js

Status: RESOLVED FIXED

(DevTools :: Framework, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

• It uses an id property that is more a forwarding prefix, so we can probably rename that.
• In the list of connections, there's an rpcs property (devtools/server/startup/worker.js#76 ) that isn't used anywhere, so we can remove it, and directly store the connection.
• rpcDeferred is an array, but is used like an object (devtools/server/startup/worker.js#33,52,94-95)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1669655 - [devtools] Cleanup worker-connector.js and startup/worker.js. r=ochameau.

• Rename id to a more explicit forwardingPrefix property
• Add comments to why we need to handle a list of connections
• Remove the rpcs property from the connections object
• Turn rpcDeferred from an array to an object, as it's used like one.

Depends on D92751

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864d323183cd
[devtools] Cleanup worker-connector.js and startup/worker.js. r=ochameau.

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/864d323183cd