1669693 - WebSocket Messages keyboard navigation doesn't work

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Ben D (:rockingskier)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

When viewing the WebSocket messages panel you should be able to navigate up and down using keyboard shortcuts.

The issue is due to the action having the wrong signature. It is designed to work with thunk but netmonitor uses thunk-with-options.

(dispatch, getState) => 

({ dispatch, getState }) => 

Actual results:

Keyboard navigation has no effect.

Expected results:

Keyboard navigation should change the selected message

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Thanks Ben! Do you want to be assigned to this bug as well?

Comment 2

[Ben D (:rockingskier)]

Yes please. The fix is super quick. Just need to work on the test.

Comment 3

[Ben D (:rockingskier)]

Attachment: Bug 1669693 - [devtools] fix WebSocket message keyboard navigation. r=honza,bomsy

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c95eb6e039a
[devtools] fix WebSocket message keyboard navigation. r=Honza,bomsy

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5c95eb6e039a