1669696 - Custom margins are not applied if a second value is changed after the error message is triggered and the “trigger” value is than changed to a valid one

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencast issue.gif

Affected versions

• 83.0a1 (2020-10-07)

Affected platforms

• Windows 10
• macOS 10.14
• Ubuntu 18.04

Steps to reproduce

1. Launch Fx
2. Make sure print.tab-modal.enabled is set on true
3. Hit Ctrl + P on any page
4. Set an invalid value for the Left (or any other option) in order to trigger the error message
5. Change the value for any other option (eg. Right)
6. Change the value from step 4 to a valid one

Expected result

• The options are validated (the red border disappear), the error message is no longer displayed, the print preview is updated according to the changes

Actual result

• The options are validated (the red border disappear), the error message is still displayed, the print preview is not updated according to the changes

Regression range

• Not a regression, introduced with the Custom margins functionality

Additional notes

• Once another modification is made inside any of the field, the issue is no longer present

Suggested severity

• S3

Comment 1

[Emma Malysz]

Attachment: Bug 1669696: update custom margins if both values are valid

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b2a95a6e071
update custom margins if both values are valid r=mstriemer

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on browser_print_margins.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Csuccess%2Cusercancel%2Crunnable&test_paths=toolkit%2Fcomponents%2Fprinting%2Ftests%2Fbrowser.ini&fromchange=0b5292f5309da950492aaff25572455520d093d0&tochange=00ae638205fc834b73b2ee9c2290009776cbddaa&selectedTaskRun=Rz-UbYE8S8qM4cTT8VxkfQ.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=319028664&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/00ae638205fc834b73b2ee9c2290009776cbddaa

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b922807f962
update custom margins if both values are valid r=mstriemer

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5b922807f962

Comment 6

[Emma Malysz]

Comment on attachment 9180752 [details]
Bug 1669696: update custom margins if both values are valid

Beta/Release Uplift Approval Request

• User impact if declined: Custom margin functionality is very buggy. They will not revalidate with new inputs
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR listed in comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No string changes
• String changes made/needed: n/a

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9180752 [details]
Bug 1669696: update custom margins if both values are valid

Approved for 83 beta 2, thanks

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8f5b95b5a11e

Comment 9

[Anca Soncutean, Desktop QA]

This issue is verified fixed with Fx 83.0b2 and Fx 84.0a1 (2020-10-20) on Windows 10, Ubuntu 18.04 and macOS 10.15.