1669728 - The Fission doorhanger cannot be accessed using keyboard navigation

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, defect, P5)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: FissionDoorhanger_KeyboardNavigation.gif

[Affected versions]:

• Firefox Nightly 83.0a1 (Build ID: 20201007094223)

[Affected Platforms]:

• Windows 10 x64
• Mac 10.15

[Prerequisites]:

• Have the latest Firefox Nightly browser installed.
• Have a new Firefox profile.
• Have the user.js for the “fission-enabled” branch downloaded to your PC.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the "about:support" page and open the profile folder.
3. Paste the user.js file from prerequisites and restart the browser.
4. Restart the browser for the second time and navigate to any website (e.g. https://www.wikipedia.org/).
5. Press the “Tab” key until any button from the “Fission” doorhanger is focused.
6. Observe the behavior.

[Expected result]:

• The buttons from the Fission experiment doorhanger are focused.

[Actual result]:

• The elements from the Fission experiment doorhanger cannot be focused.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

andreio, is there anything I can or should do in or around https://github.com/mozilla/messaging-system-inflight-assets/pull/156 to allow keyboard navigation?

Comment 2

[Andrei Oprea [:andreio]]

Keyboard access works, it was defined as part of the strings. So CTRL+SHIFT+<KEY> to access the message. It also works by focusing the browser chrome and <tab>ing through the elements until you get to focus the panel (but unfortunately the PopupNotification code does not have any special styling for button focus).

https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/browser/locales/en-US/browser/newtab/asrouter.ftl#279-282

Comment 3

[Simona Rosu [:srosu], Ecosystem QA]

We have been able to access the functionality of the buttons by using “Alt + O” or ”Alt + L” keys, but the doorhanger cannot be accessed using “Tab” key. The buttons can be focused using “Tab” once one of them has been long-clicked, but that requires the use of a mouse. Considering this I will reopen the issue.

Comment 4

[Andrei Oprea [:andreio]]

STR:

1. Enable Accessibility -> VoiceOver on OSX (not required but this adds a prominent focus ring around the UI elements where there usually aren't any)
2. Have the Doorhanger showing
3. Focus the Awesomebar (CMD+L)
4. Use SHIFT+TAB to move focus backwards through the UI elements
   After a few repetitions of (3) (going through the home, refresh, back buttons and then the tabs) the Notification is focused.

Please let me know if this works or maybe it's a Windows only bug.

Comment 5

[Andrei Oprea [:andreio]]

Attachment: accessibility_focus_with_keyboard.png

Focus ring from VoiceOver assist

Comment 6

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly experiment (M6b). Nice to have, but doesn't need to block launching the experiment.

Waiting for QA to determine whether this bug is Windows-specific. Is this a bug in Fission's use of the doorhanger API or in the doorhanger implementation itself?

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

We have retested this issue using the provided STR from the above comment on Windows 10 x64, Mac 10.14.6, and Mac 10.15.6, but unfortunately, we have not been able to focus the buttons from the Fission doorhanger.

Comment 8

[Neha Kochar [:neha]]

This seems to be from the doorhanger API but Andrei was unable to reproduce the issue. Lowering priority until we see more reports for this. We will re-review this before M7 completes.

Comment 9

[Neha Kochar [:neha]]

Since Fission doorhanger will be Nightly-only, this does not block M7 for Beta. Also, we haven't received any user reports of this issue.

Comment 10

[Chris Peterson [:cpeterson]]

WONTFIX because we will be removing the Fission doorhanger soon in bug 1693207.

Comment 11

[Chris Peterson [:cpeterson]]

WONTFIX because we will be removing the Fission doorhanger soon in bug 1693207.