1669742 - window.matchMedia result doesn't match original query for aspect-ratio 1/1

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Ksenia Berezina [:ksenia] on leave until 09/15]

Attachment: 15124-fenix.html

This was originally reported in https://github.com/mozilla-mobile/fenix/issues/15124

When querying for window.matchMedia for (max-aspect-ratio: 1/1) the result contains a shorter version (max-aspect-ratio: 1). Even though the serialization is correct, the site expecting the result to match the original query.

Comment 1

[Mats Palmgren (inactive)]

https://drafts.csswg.org/css-values-4/#ratio-value
"The second <number> is optional, defaulting to 1. However, <ratio> is always serialized with both components."

Comment 2

[Sean Voisen (:svoisen)]

emilio: Is comment 1 contrary to what you wrote in https://github.com/mozilla-mobile/fenix/issues/15124#issuecomment-704845597?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

So there are two issues here:

• The space around the slash. That is intentional per the discussion here: https://github.com/w3c/csswg-drafts/issues/4282
• The /1 disappearing per the shortest serialization principle. That contradicts the spec. The sentence in comment 1 is from two weeks ago (https://github.com/w3c/csswg-drafts/issues/5561).

So we should:

• File a bug on chrome to add spaces around the /.
• Adopt the resolution in https://github.com/w3c/csswg-drafts/issues/5561.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1669742 - Always serialize ratio with both components. r=boris,#style

Comment 5

[Karl Dubost💡 :karlcow]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

• File a bug on chrome to add spaces around the /.

Emilio opened https://bugs.chromium.org/p/chromium/issues/detail?id=1138849

Note that there is a third issue which is about the order.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b11ef23004d6
Always serialize ratio with both components. r=boris

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b11ef23004d6

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26386 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot