1669772 - Stop calling nsPrintSettingsService::GetDefaultPrintSettingsForPrinting in nsGlobalWindowOuter::PrintOuter

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P2)

Description

[Jonathan Watt [:jwatt]]

nsPrintSettingsService::GetDefaultPrintSettingsForPrinting gets a settings object that may well have completely different settings to what the print preview/print will set. Using that to get a settings object in nsGlobalWindowOuter::PrintOuter to pass to nsPrintJob::Print/PrintPreview isn't great.

It's not possible to get the same settings object at this point in the code as will be chosen by the frontend code, because our sandboxing goals mean that we can't be accessing nsIPrinterList in the content process.

Ideally I think the code would be refactored so that we only do the static cloning under nsGlobalWindowOuter::PrintOuter, and do not try to reflow the document until the print preview/print on the parent side takes ownership of the temporary docshell and then passes a settings object over to the content process via nsFrameLoader::Print/PrintPreview.

Emilio, would you be able to take a look at this?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1669772 - Don't do a silly print preview from window.print() with the new tab modal UI. r=jwatt

The comment should be self-descriptive. We keep cloning the doc sync and
the UI will preview that doc, so it works out nicely and we do less
work.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

So like this? I don't think this is observable/testable, but let me know if you think it is and I can try to add a test.

Comment 3

[Jonathan Watt [:jwatt]]

Yeah, that's great. Thanks!

Comment 4

[Jonathan Watt [:jwatt]]

(And no, I don't think this is testable.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a31ce80459a
Don't do a silly print preview from window.print() with the new tab modal UI. r=jwatt

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3a31ce80459a