1669790 - Cleanup CompilationInfo::instantiateStencils for delazification case

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

• InstantiateScriptStencils isn't necessary for delazification
• stencil.scriptData[CompilationInfo::TopLevelIndex].isModule() branch isn't necessary for delazification

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1669790 - Part 1: Do not call InstantiateScriptStencils on delazification. r?tcampbell!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1669790 - Part 2: Do not check isModule on delazification. r?tcampbell!

Depends on D92901

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/735e4f5d61e4
Part 1: Do not call InstantiateScriptStencils on delazification. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a3ea444d2332
Part 2: Do not check isModule on delazification. r=tcampbell

Comment 4

[Razvan Maries]

Backed out for SM Bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cdebug%2Cspidermonkey%2Cbuilds%2Cspidermonkey-sm-compacting-linux64%2Fdebug%2Ccgc&revision=3884042fe3a8da12ece4d92b3d014b6e50ec0887&selectedTaskRun=FsmQhet7TauCNInOYqTICA.0

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318321482&repo=autoland&lineNumber=30004

Backout: https://hg.mozilla.org/integration/autoland/rev/ba389884ca470e850567e236aad73d6b6dff8061

Comment 5

[Tooru Fujisawa [:arai]]

it's bug 1670323, and I'll fix it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f675ccaeba5
Part 1: Do not call InstantiateScriptStencils on delazification. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/91821418b41d
Part 2: Do not check isModule on delazification. r=tcampbell

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6f675ccaeba5
https://hg.mozilla.org/mozilla-central/rev/91821418b41d