Closed Bug 1669795 Opened 4 years ago Closed 4 years ago

Add tests for automatic source-compression after JS parsing

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

Details

Attachments

(1 file)

The off-thread parsing code calls the source-compression dispatch, but we don't actually have any tests to catch missing calls.

https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/js/src/vm/HelperThreads.cpp#1947

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fb796dfd059
Add tests off-thread-compile source-compression. r=jonco
Attachment #9180235 - Attachment description: Bug 1669795 - Add tests off-thread-compile source-compression. r?jonco → Bug 1669795 - Add tests for automatic source-compression. r?jonco

Updated to cover main-thread too since we were missing tests for that as well.

Flags: needinfo?(tcampbell)
Summary: Add tests for source-compression for off-thread parsing → Add tests for automatic source-compression after JS parsing
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe150f2d7833
Add tests for automatic source-compression. r=jonco
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: