1669833 - nsChromeRegistry.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Core :: General, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/dom/base/ContentIterator.cpp#267-269

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Akshat [:baka]]

Attachment: Bug 1669833 - Removed else after the return statement. r?jfkthame

Comment 2

[Akshat [:baka]]

Attachment: Bug 1669833 - Removed else after the return statement and fixed trailing whitespace. r=jfkthame

Depends on D93873

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39a48c3abc33
Removed else after the return statement. r=jfkthame

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/39a48c3abc33

Comment 5

[Rafal Bielski]

Attachment: Bug 1669833 - Fix readability-else-after-return warnings. r?masayuki

Comment 6

[Rafal Bielski]

It seems the patch from akshat.dixit71 actually fixed Bug 1669834 (nsChromeRegistry.cpp) rather than this Bug 1669833 (ContentIterator.cpp). Should this one be reopened?

I just submitted a patch for ContentIterator.cpp, which is my first contribution! I also found Bug 1658273 suggesting that this specific case may be incorrectly flagged as a problem. However, there are also other cases of [readability-else-after-return] in the same file which are not as debatable, so I decided to still submit the patch.

Comment 7

[Andrew McCreight [:mccr8]]

(In reply to Rafal Bielski from comment #6)

It seems the patch from akshat.dixit71 actually fixed Bug 1669834 (nsChromeRegistry.cpp) rather than this Bug 1669833 (ContentIterator.cpp). Should this one be reopened?

I think it would make the most sense to file a new bug for ContentIterator, and attach your patch to that bug. Thanks.

Comment 9

[Andrew McCreight [:mccr8]]

I'll rename this bug to mention what actually ended up being fixed here.

Comment 10

[Andrew McCreight [:mccr8]]

I just went ahead and filed bug 1673913. You can attach your patch there, please. Thanks.

Comment 11

[Phabricator Automation]

Comment on attachment 9182829 [details]
Bug 1669833 - Fix readability-else-after-return warnings. r?masayuki

Revision D94243 was moved to bug 1673913. Setting attachment 9182829 [details] to obsolete.

Comment 12

[Rafal Bielski]

Thank you Andrew, I moved the patch to Bug 1673913