1669838 - Add the SwComposite thread to all the presets

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Markus Stange [:mstange]]

https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/gfx/webrender_bindings/src/swgl_bindings.rs#625

Comment 1

[Markus Stange [:mstange]]

The SwComposite thread, if present, is interesting whenever the Renderer thread is interesting. So it would make sense to include it in all presets that have the Renderer thread enabled.
The SwComposite thread is only used in the Software WebRender configuration, which is currently off-by-default and not ready for dogfooding yet.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I see you've assigned yourself, so you probably know, but just in case:
Presets are defined in devtools/client/performance-new/popup/background.jsm.js

Comment 3

[Florian Quèze [:florian]]

(In reply to Markus Stange [:mstange] from comment #1)

The SwComposite thread, if present, is interesting whenever the Renderer thread is interesting. So it would make sense to include it in all presets that have the Renderer thread enabled.

I think some of the presets have the Renderer thread not because they are interested in it, but because not including it breaks the screenshots feature.

(In reply to Gerald Squelart [:gerald] (he/him) from comment #2)

I see you've assigned yourself, so you probably know, but just in case:
Presets are defined in devtools/client/performance-new/popup/background.jsm.js

It's also included at https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/tools/profiler/core/platform.cpp#3975, for the reason I stated above.

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1669838 - Add the SwComposite thread to the presets "Firefox Platform", "Firefox Front-End", "Firefox Graphics" and "Media". r=gregtatum

These are the presets that I think are most likely in use by people
who report performance bugs with the browser.

The SwComposite thread is used when software webrender is enabled,
except on macOS where it is never used. In those configurations, the
samples from the SwComposite thread are interesting in the same cases
when the samples from the Renderer thread are interesting, i.e. whenever
the performance bottleneck is on the rendering side.
However, we do not need to profile the SwComposite thread in all cases where
we profile the Renderer thread, because in some configurations the Renderer
thread is only present so that the screenshot markers are captured. The
SwComposite thread does not have screenshot markers.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06e469d6b0df
Add the SwComposite thread to the presets "Firefox Platform", "Firefox Front-End", "Firefox Graphics" and "Media". r=gregtatum

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/06e469d6b0df