1669851 - Decouple liftParserAtomToJSAtom from CompilationInfo

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

CompilationInfo::liftParserAtomToJSAtom and ParserAtom::toJSAtom uses only CompilationInput.atoms.
there's no need to take the entire CompilationInfo.
This will help bug 1669718 to introduce another root type for delazification.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1669851 - Part 1: Decouple liftParserAtomToJSAtom from CompilationInfo. r?djvj!

Depends on D92903

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1669851 - Part 2: Make ScopeStencil::createSpecificScope to receive CompilationInput. r?djvj!

Depends on D92904

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1669851 - Part 3: Make ScopeStencil::createScope to receive CompilationInput. r?djvj!

Depends on D92905

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15c9ef0258da
Part 1: Decouple liftParserAtomToJSAtom from CompilationInfo. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7e8fd3c22347
Part 2: Make ScopeStencil::createSpecificScope to receive CompilationInput. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7714b8069e44
Part 3: Make ScopeStencil::createScope to receive CompilationInput. r=tcampbell

Comment 5

[Razvan Maries]

Backed out for SM Bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cdebug%2Cspidermonkey%2Cbuilds%2Cspidermonkey-sm-compacting-linux64%2Fdebug%2Ccgc&revision=3884042fe3a8da12ece4d92b3d014b6e50ec0887&selectedTaskRun=FsmQhet7TauCNInOYqTICA.0

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318321482&repo=autoland&lineNumber=30004

Backout: https://hg.mozilla.org/integration/autoland/rev/ba389884ca470e850567e236aad73d6b6dff8061

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee553fa6583c
Part 1: Decouple liftParserAtomToJSAtom from CompilationInfo. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1de0e1c3f86f
Part 2: Make ScopeStencil::createSpecificScope to receive CompilationInput. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/f84c5ac6b8c6
Part 3: Make ScopeStencil::createScope to receive CompilationInput. r=tcampbell

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ee553fa6583c
https://hg.mozilla.org/mozilla-central/rev/1de0e1c3f86f
https://hg.mozilla.org/mozilla-central/rev/f84c5ac6b8c6