Closed Bug 1669889 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 26035 - Revert "Fix that mask containing image with clip-path can not apply to client"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26035 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26035
Details from upstream follow.

b'Hyunjune Kim <hyunjune.kim@samsung.com>' wrote:

Revert "Fix that mask containing image with clip-path can not apply to client"

This reverts commit 292c16f2ef806c8941e3228b650b61d4c1a880ec.

Reason for revert: After a patch[1], this issue is fixed. So this patch is not needed anymore.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2050382

Original change's description:

Fix that mask containing image with clip-path can not apply to client

When image contained mask is loading, it touches a mask flag called
|computed_invalidation_mask_|.
Because |MarkForLayoutAndParentResourceInvalidation| is called in
|ImageChanged| without layout while loading, so this flag would be
changed without clear. And this flag is used in the next layout.
Actually this mask can not apply to client element in next time.
This patch clears the mask flag in pre-paint time.

Bug: 1086070
Change-Id: I55a7a16faafe4eeefac88e8e15e6d3b18b097acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432151
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Commit-Queue: Hyunjune Kim \<hyunjune.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#813061}

TBR=fs@opera.com,hyunjune.kim@samsung.com,schenney@chromium.org

Change-Id: Ifca23ff31590ebc13e1b5a7492c04724847e748f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1086070

Reviewed-on: https://chromium-review.googlesource.com/2460527
WPT-Export-Revision: 051f0c57d0da58071c3ce37aecca90240dfd8b2f

PR 26035 applied with additional changes from upstream: 0111e72506119a74b545f4559b3711d2a43601fd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.