Open Bug 1669904 Opened 1 year ago Updated 8 months ago

Stop using PrintUtils.getPrintSettings in the new printing UI

Categories

(Toolkit :: Printing, defect, P2)

defect

Tracking

()

People

(Reporter: jwatt, Unassigned)

References

Details

(Whiteboard: [print2020] [old-ui-] )

Currently we have this:

https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/toolkit/components/printing/content/print.js#221

Using that means we're taking the system default printer's name, and using that to get settings using the initPrintSettingsFromPrinter()/initPrintSettingsFromPrefs() methods. If the user has never printed using that printer before, then we're going to end up with a default initialized print settings without taking into account the limitations of the printer, such as unwritable margins. That's a shame, since we actually have the nsIPrinter for that printer at that point in the code and could call createDefaultSettings() on it.

I think ultimately we need some new API to create the settings for a printer while copying over as many as are valid from another printer. In this case, creating a settings object for the default printer (or the first printer in the nsIPrinterList if none is selected as the default), and then copying over as many settings as possible from the Save as PDF printer. That API would be closely related to whatever we end up with for bug 1669149, and probably should feed into the design of what we end up with there.

Whiteboard: [print2020_v84][old-ui-] → [print2020_v85][old-ui-]
Severity: -- → S3

(Moving bugs to 86, part 1.)

Whiteboard: [print2020_v85][old-ui-] → [print2020_v86][old-ui-]

Moving things to 88, cause we're mostly on Proton these days…

Whiteboard: [print2020_v86][old-ui-] → [print2020_v88] [old-ui-]
Whiteboard: [print2020_v88] [old-ui-] → [print2020] [old-ui-]
You need to log in before you can comment on or make changes to this bug.