1669933 - Reftests for bug 1564128 don't test what they want to test.

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

https://phabricator.services.mozilla.com/D73140 added a bunch of reftest-paged reftests, but reftest-paged don't trigger the document/animation cloning stuff that those tests are supposed to test.

They should be wpt print reftests (maybe internal, in testing/web-platform/mozilla since our behavior here is probably not specified).

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Gah. Yeah we should rewrite them as mozilla-only wpt.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Hmm looks like animations in print preview don't work as expected?

I will check it later.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1669933 - Migrate reftests for animation in print document as wpt print test. r?boris

Comment 4

[Hiroyuki Ikezoe (:hiro)]

FWIW, I push the change to migrate them as wpt print test, all of them fail though.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1669933 - Use same frame structure as the test HTML in pseudo-animations-print-ref.html. r?boris

The different structure causes fuzzy result.

Depends on D93020

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1669933 - Register cloning paused animations to PendingAnimationTracker to make sure the animations are painted in printing documents. r?boris

Without PendingAnimationTracker, we can't make the refresh driver keep ticking
for the animations until we are ready to paint the printing documents. In other
words we do stop ticking [1] in DocumentTimeline::MostRecentRefreshTimeUpdated.

[1] https://searchfox.org/mozilla-central/rev/25d5a4443a7e13cfa58eff38f1faa5e69f0b170f/dom/animation/DocumentTimeline.cpp#168,183-192

Depends on D94255

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5524a3282260
Migrate reftests for animation in print document as wpt print test. r=boris
https://hg.mozilla.org/integration/autoland/rev/fe2f9992992b
Use same frame structure as the test HTML in pseudo-animations-print-ref.html. r=boris
https://hg.mozilla.org/integration/autoland/rev/88e92f9a0335
Register cloning paused animations to PendingAnimationTracker to make sure the animations are painted in printing documents. r=boris

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5524a3282260
https://hg.mozilla.org/mozilla-central/rev/fe2f9992992b
https://hg.mozilla.org/mozilla-central/rev/88e92f9a0335

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e9cf639b261
set css animation tests as failing with error. a=jgraham-on-matrix CLOSED TREE DONTBUILD

Comment 10

[Sandor Molnar[:smolnar]]

Backed out because failures were not from wptsync

Backout link: https://hg.mozilla.org/integration/autoland/rev/72ddac4860373e30a1815bf645a8782dfaf511d7

Comment 11

[Hiroyuki Ikezoe (:hiro)]

I have no idea what happened there. The changes by me has been merged in m-c. Bug 1682159 made animations-print.html test error as in comment 9, then it got backed out? (That said, it's possible that bug 1682159 un-wallpapered a pre-existing issue.)

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry for the confusion, I shouldn't have used this bug number.