1669966 - irregexp build failure on x86 with gcc 9.3.0: comparison of integer expressions of different signedness

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Nicolas B. Pierron [:nbp]]

Compiling SpiderMonkey for x86 (arm-simulator build) produces the following error messages with gcc:

…/js/src/irregexp/util/VectorShim.h:72:24: error: comparison of integer expressions of different signedness: 'const size_t' {aka 'const unsigned int'} and 'int' [-Werror=sign-compare]
   72 |     MOZ_ASSERT(length_ <= std::numeric_limits<int>::max());
…/dist/include/mozilla/Likely.h:17:48: note: in definition of macro 'MOZ_UNLIKELY'
   17 | #  define MOZ_UNLIKELY(x) (__builtin_expect(!!(x), 0))
      |                                                ^
…/dist/include/mozilla/Assertions.h:386:23: note: in expansion of macro 'MOZ_CHECK_ASSERT_ASSIGNMENT'
  386 |     if (MOZ_UNLIKELY(!MOZ_CHECK_ASSERT_ASSIGNMENT(expr))) {    \
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
…/dist/include/mozilla/Assertions.h:404:31: note: in expansion of macro 'MOZ_ASSERT_HELPER1'
  404 | #define MOZ_ASSERT_GLUE(a, b) a b
      |                               ^
…/dist/include/mozilla/Assertions.h:412:5: note: in expansion of macro 'MOZ_ASSERT_GLUE'
  412 |     MOZ_ASSERT_GLUE(                                                    \
      |     ^~~~~~~~~~~~~~~
…/js/src/irregexp/util/VectorShim.h:72:5: note: in expansion of macro 'MOZ_ASSERT'
   72 |     MOZ_ASSERT(length_ <= std::numeric_limits<int>::max());
      |     ^~~~~~~~~~

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1669966: Don't compare size_t to int r=nbp

The same 'issue' exists in the upstream V8 code this was copied from: https://github.com/v8/v8/blob/c4a7bd869851ecbebc07e83db970c878174f134a/src/utils/vector.h#L49

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf878ce3529b
Don't compare size_t to int r=nbp

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bf878ce3529b