1669972 - ARM backend: EmitRemainderOrQuotient argument isSigned is wrongly named.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Nicolas B. Pierron [:nbp]]

EmitRemainderOrQuotient is being called with isUnsigned from its 2 caller, and the isSigned argument is interpreted as isUnsigned, which makes its uses confusing.

We should simply replace isSigned by isUnsigned inside EmitRemainderOrQuotient without inverting the conditions.

Comment 1

[Lars T Hansen [:lth]]

Or, there could be 'enum class Signedness { Signed, Unsigned }'... I'm joking a little - we've been using that kind of structure in the wasm code and I'm not sure that it pays for itself in clarity, since enums with two members eventually always seem to be cast to bool, and then the confusion comes back in.

Comment 2

[Nicolas B. Pierron [:nbp]]

Attachment: Bug 1669972 - ARM EmitRemainderOrQuotient: Rename isSigned to isUnsigned to match the intended meaning.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00fa7c468cec
ARM EmitRemainderOrQuotient: Rename isSigned to isUnsigned to match the intended meaning. r=tcampbell

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/00fa7c468cec