1669990 - Print preview closes if the "escape" keyboard button is pressed for dropdown menus

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Affected versions

• Firefox 83.0a1 (BuildId:20201008094950)
• Firefox 82.0b8 (BuildId:20201006142214)

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit
• macOS 10.14

Steps to reproduce

1. Launch Firefox.
2. Access a random webpage.
3. Open the print preview.
4. Open a dropdown menu (ex: Paper Size, Margins, Destination,etc).
5. While the dropdown menu is open, hit the escape keyboard button in order to close the dropdown menu.

Expected result

• The dropdown menu in question is closed.

Actual result

• The entire print preview gets closed.

Regression Window

• I don’t think that this is a regression.

Additional Information

• [Suggested severity] S3 or S4
• As a side note, Chrome seems to align with the mentioned expected result.

Comment 1

[Mark Striemer [:mstriemer]]

Gijs, does this seem like something TabDialogBox should handle? There could be a bunch of edge cases here I'd imagine but I believe TabDialogBox would be the one closing the dialog.

Comment 2

[:Gijs (he/him)]

(In reply to Mark Striemer [:mstriemer] from comment #1)

Gijs, does this seem like something TabDialogBox should handle? There could be a bunch of edge cases here I'd imagine but I believe TabDialogBox would be the one closing the dialog.

Gonna redirect this to Paul - also because I'm about to go on PTO. :-)

Comment 3

[Paul Zühlcke [:pbz]]

The SubDialog keypress handler is closing the dialog:
https://searchfox.org/mozilla-central/rev/c2e3ac11be4837718c2604e58085fbc8252b69dd/toolkit/modules/SubDialog.jsm#609

I think we should move the esc key handling into the print dialog. The dialog elements of the other SubDialog consumers (preferences, prompts) already do this.

Comment 4

[Paul Zühlcke [:pbz]]

Ok, turns out the popup code cancels the keydown system event. But since the SubDialog code uses a normal event listener it still gets keydown and closes the dialog. Thanks for debugging this, Gijs!

Comment 5

[Paul Zühlcke [:pbz]]

Attachment: Bug 1669990 - SubDialog: Use system event listener for escape key. r=gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5066eae18c2d
SubDialog: Use system event listener for escape key. r=Gijs

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5066eae18c2d

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 9

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using FIrefox 85.0b4 (BuildId:20201220193140) and Firefox 86.0a1 (BuildId:20201221155804) on Windows 10 64bit, macOS 10.14 and Ubuntu 20.04