1670027 - Print selection is disabled inside the system modal if the print preview destination was set to “Save to PDF”

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: SelectionSaveToPDF.gif

Affected versions

• Firefox 83.0a1 (BuildId:20201008094950)
• Firefox 82.0b8 (BuildId:20201006142214)
• Firefox 81.0.1 (BuildId:20200930150533)

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit
• macOS 10.14

Steps to reproduce

1. Launch Firefox.
2. Access a random webpage.
3. Select a random string from the page.
4. Open the print preview.
5. Select the “Save to PDF” destination.
6. Click the “Print using the system dialog”.
7. Switch between the available destinations from the System dialog.

Expected result

• The “Selection” radio button is available.

Actual result

• The “Selection” radio button is not available.

Regression Window

• I don’t think that this is a regression.

Additional Information

• [Suggested severity] S3
• For further information regarding this issue please observe the attached screencast.

Comment 1

[Jonathan Watt [:jwatt]]

I guess because although we set isPrintSelectionRBEnabled, that setting isn't on the list of propagated settings.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

(Moving bugs to 86, part 1.)

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Moving things to 88, cause we're mostly on Proton these days…

Comment 4

[Matthew N. [:MattN]]

Just hit this bug too (due to a separate issue of printing from the modal dialog not working at all, just flickering upon clicking "Save").

We need to set isPrintSelectionRBEnabled after getting default system printer settings for the system dialog (since we can't use the current settings which refer to the fake PDF printer): https://searchfox.org/mozilla-central/rev/3ba42a92cea3e61163091e7fe4d22bcda74a1e5a/toolkit/components/printing/content/print.js#287,302-305,307

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1670027 - Always compute isPrintSelectionRBEnabled for the settings passed to the system print dialog. r=mstriemer

When the Mozilla PDF printer is selected, a new settings object was created without the value of isPrintSelectionRBEnabled computed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98cbaebbfa00
Always compute isPrintSelectionRBEnabled for the settings passed to the system print dialog. r=mstriemer

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/98cbaebbfa00

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:MattN, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue on an affected Nightly build from 2020-10-08 on Win 10 x64.

Verified as fixed on Firefox 92.0.1 (20210922161155) across the following platforms: Win 10 x64, Ubuntu 20.04 and macOS 10.15. The selection button is available, it is not grayed out anymore.