1670033 - Implement Intl Enumeration API

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement, P3)

Description

[Yulia Startsev [:yulia]]

+++ This bug was initially created as a clone of Bug #1670018 +++

Currently at stage 2

Summary from the proposal:

List supported values of options in pre-existing ECMA 402 API.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 2: Implement "calendar" support for the "Intl Enumeration API" proposal. r=tcampbell!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 8: Add tests for canonical time zones. r=tcampbell!

Depends on D116010

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 3: Implement SupportedValues iterator.

Depends on D116011

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 1: Add CompareStrings for JSLinearString arguments. r=tcampbell!

The next part will sort linear strings, so in preparation for that, add a
new CompareStrings overload. Also change the parameters to const, so the
function can be called with const arguments.

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 3: Implement "collation" support for the "Intl Enumeration API" proposal. r=tcampbell!

Depends on D116010

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 4: Implement "currency" support for the "Intl Enumeration API" proposal. r=tcampbell!

Depends on D120603

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 5: Implement "numberingSystem" support for the "Intl Enumeration API" proposal. r=tcampbell!

Depends on D120604

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 6: Implement "timeZone" support for the "Intl Enumeration API" proposal. r=tcampbell!

Depends on D120605

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1670033 - Part 7: Implement "unit" support for the "Intl Enumeration API" proposal. r=tcampbell!

Depends on D120606

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5113a5c9d104
Part 1: Add CompareStrings for JSLinearString arguments. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e5214a5c19ce
Part 2: Implement "calendar" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/17d3d039f9f9
Part 3: Implement "collation" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/d9556470db5f
Part 4: Implement "currency" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ddfb65ae6d94
Part 5: Implement "numberingSystem" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/dba96edd4ef9
Part 6: Implement "timeZone" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/792df14778c6
Part 7: Implement "unit" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/fcdca501deb3
Part 8: Add tests for canonical time zones. r=tcampbell

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing sm build bustages in IntlObject. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/d5786bee3788efcc0942840b14b450bc70054917
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=fcdca501deb3630b93ac6447b372cc7e9f9da49a&selectedTaskRun=HODvf6LfTXWRJBmuYz0WBw.0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=349756370&repo=autoland&lineNumber=94423

Comment 12

[André Bargull [:anba]]

Looks like the code doesn't compile on GCC, whereas it is accepted by Clang. Let's see which workarounds are needed here...

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30467188ac38
Part 1: Add CompareStrings for JSLinearString arguments. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/0f1250ac5b84
Part 2: Implement "calendar" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/602274ba8d1a
Part 3: Implement "collation" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/188edb43f141
Part 4: Implement "currency" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e5c156bd2ac5
Part 5: Implement "numberingSystem" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/5eab40f17dff
Part 6: Implement "timeZone" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1cf112afb9ef
Part 7: Implement "unit" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/11f4374e88ca
Part 8: Add tests for canonical time zones. r=tcampbell

Comment 14

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustage in IntlObject. CLOSED TREE
Backout link : https://hg.mozilla.org/integration/autoland/rev/75f568ff37353dcca72f65de6fc7f5391040e588
Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains-clang%2Fdebug%2Cbbc&revision=11f4374e88ca34427ddf097418df731ae02d939a&selectedTaskRun=XxYLJvalT3usA6KAk30cqw.0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=349781080&repo=autoland&lineNumber=51284

Comment 15

[André Bargull [:anba]]

The current patch works correctly with Clang >=6, but needs a small modification to be compatible with Clang 5.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8894af262f14
Part 1: Add CompareStrings for JSLinearString arguments. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/4784eb45889d
Part 2: Implement "calendar" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/64343df57cd4
Part 3: Implement "collation" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9899d048af19
Part 4: Implement "currency" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/6ee2ee32d223
Part 5: Implement "numberingSystem" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e31aa75e0933
Part 6: Implement "timeZone" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/791926c9f804
Part 7: Implement "unit" support for the "Intl Enumeration API" proposal. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b7e76765e759
Part 8: Add tests for canonical time zones. r=tcampbell

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8894af262f14
https://hg.mozilla.org/mozilla-central/rev/4784eb45889d
https://hg.mozilla.org/mozilla-central/rev/64343df57cd4
https://hg.mozilla.org/mozilla-central/rev/9899d048af19
https://hg.mozilla.org/mozilla-central/rev/6ee2ee32d223
https://hg.mozilla.org/mozilla-central/rev/e31aa75e0933
https://hg.mozilla.org/mozilla-central/rev/791926c9f804
https://hg.mozilla.org/mozilla-central/rev/b7e76765e759

Comment 18

[Hamish Willee]

Docs work for this can be tracked in https://github.com/mdn/content/issues/8618

Is this shipped? It doesn't look like there is any restriction to nightly or any preference, but I wanted to make sure before starting work.

Comment 19

[André Bargull [:anba]]

Yes, this feature is enabled by default and will ship in Firefox 93.

Comment 20

[Hamish Willee]

Thanks very much. All the docs and compatibility work done for this (you can see in MDN 8618 though still being reviewed. Any comments or feedback welcome.
I will mark dev-doc-complete.

Comment 21

[André Bargull [:anba]]

The MDN docs look good to me!