1670067 - OpenPGP message header status icons not visible

Status: RESOLVED DUPLICATE of bug 1662279

(MailNews Core :: Security: OpenPGP, defect, P1)

Description

[Alessandro Castellani [:aleca]]

This issue appeared with release 78.3.2 and it wasn't affecting 78.3.1

The Encryption status buttons and icons in the Header area of the Message Pane is randomly not visible, even if the openpgp.enable pref is set to TRUE.
Toggling the pref fixes the problem, but it's only temporary as the problem presents itself again when relaunching TB.
Curiously enough, the problem is fixed even if the openpgp.enable pref gets set to FALSE.

Pushlog of the recent 78 uplifts: https://hg.mozilla.org/releases/comm-esr78/pushloghtml

When building 78 locally, this problem appears randomly, 1 out of 5 times I launch TB, the encryption status is visible.
During a "good run", this is the console output:

console.debug: "public keys: 0, secret keys: 0"
console.debug: "0 protected and 0 unprotected keys"
console.debug: "Successfully loaded OTR library libotr.so.5 from system's standard library locations"

During a "bad run", this is the console output:

JavaScript error: resource://gre/modules/ActorManagerChild.jsm, line 297: TypeError: singletons is null
JavaScript error: resource://gre/modules/ActorManagerChild.jsm, line 297: TypeError: singletons is null
JavaScript error: resource://gre/modules/ActorManagerChild.jsm, line 297: TypeError: singletons is null
console.debug: "Successfully loaded OTR library libotr.so.5 from system's standard library locations"
console.debug: "public keys: 0, secret keys: 0"
console.debug: "0 protected and 0 unprotected keys"

Comment 1

[Alessandro Castellani [:aleca]]

I'm struggling a bit in finding the regression on this. Magnus, would you be able to investigate this?

Comment 2

[Magnus Melin [:mkmelin]]

What could have regressed this is very likely https://hg.mozilla.org/releases/comm-esr78/rev/92ed7694c28718469ddaac9908d17a7d3aaebe26

Comment 3

[Wayne Mery (:wsmwk)]

bug 1665493 seems reasonable.

Comment 4

[Rob Lemley [:rjl]]

Here's a try build with bug 1665493 backed out.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d7b1d50c515305f63efc08713cef928643cf5c01

I started this build up a couple dozen times and did not run into the singleton error reported above. So it seems that this is the regressing bug.

Comment 5

[Alessandro Castellani [:aleca]]

I'll test the try build and report back.

Comment 6

[Alessandro Castellani [:aleca]]

(In reply to Rob Lemley [:rjl] from comment #4)

Here's a try build with bug 1665493 backed out.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d7b1d50c515305f63efc08713cef928643cf5c01

I tested this and the icons show up properly, so that's a confirmation that bug 1665493 caused the issue.

I think this issue have been fixed on trunk by bug 1662279, which landed on 82.0b3.
Rob, did you check if the issue is present in 82.0b2 and not on 82.0b3?

Comment 7

[Rob Lemley [:rjl]]

I've not checked 82.0b2 or the prebuilds of 80.0b3 yet. I won't have a chance for a few hours so if yolu or anyone else can in the meantime please do.

Comment 8

[Rob Lemley [:rjl]]

It's not showing up for me in either 82.0b2 or 82.0b1 (multiple attempts with each version), which is when bug 1665493 was fixed on beta. I believe we are on the right path.. sort of.. I suspect that while the fix for bug 1665493 triggered the bug, i believe there to be a change possibly in toolkit having to do with async calls and singletons behind it all. That's pure speculation and I have neither anything to back that statement up nor much knowledge in that area to even know where to look. ☹️