1670191 - Remove confusing mentions about remote debugging in target-mixin's jsdoc

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

Spotted while reviewing https://phabricator.services.mozilla.com/D91559

In some spots in target-mixin.js we refer to "remote debugging":

    /**
     * Setup listeners for remote debugging, updating existing ones as necessary.
     */
    _setupRemoteListeners() {
      // ...
    }

    /**
     * Teardown listeners for remote debugging.
     */
    _teardownRemoteListeners() {
      // ...
    }

This can be quite confusing and lead to think this is only used for "remote debugging" (as in Remote Debugging via about:debugging). Whereas I think it simply refers to remote tabs, ie e10s tabs, which is basically always true now anyway.

We should remove those mentions from the comments and rename the methods.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1670191 - [devtools] Remove mentions about remote debugging in target-mixin

Remote debugging in those method names and comments refered to e10s.
Nowadays remote debugging is rather used to talk about remote "browser" debugging, via about:debugging.
The comments give the false impression that those events are only used for about:debugging, which is not true.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e2735ca642f
[devtools] Remove mentions about remote debugging in target-mixin r=nchevobbe

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1e2735ca642f