1670385 - Permafailing tier 2 [mach] ValueError: no such test method in <class 'mach.test.common.TestBase'>: runTest on mach/test/test_commands.py

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Natalia Csoregi [:nataliaCs]]

Push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&selectedTaskRun=BueSlQmtTAax_clekpvKTQ.0&searchStr=mach&revision=5abe1c13c7b37cdf5b03d3063530560981a3d253

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318249397&repo=mozilla-central&lineNumber=134

[task 2020-10-10T09:44:50.747Z] 0:07.70 ==================================== ERRORS ====================================
[task 2020-10-10T09:44:50.748Z] 0:07.70 ____________________ ERROR at setup of test_mach_completion ____________________
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 @pytest.fixture
[task 2020-10-10T09:44:50.748Z] 0:07.70 def run_mach():
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 > tester = TestBase()
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 python/mach/mach/test/test_commands.py:30:
[task 2020-10-10T09:44:50.748Z] 0:07.70 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 self = <mach.test.common.TestBase testMethod=runTest>, methodName = 'runTest'
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 def init(self, methodName='runTest'):
[task 2020-10-10T09:44:50.748Z] 0:07.70 """Create an instance of the class that will use the named test
[task 2020-10-10T09:44:50.748Z] 0:07.70 method when executed. Raises a ValueError if the instance does
[task 2020-10-10T09:44:50.748Z] 0:07.70 not have a method with the specified name.
[task 2020-10-10T09:44:50.748Z] 0:07.70 """
[task 2020-10-10T09:44:50.748Z] 0:07.70 self._testMethodName = methodName
[task 2020-10-10T09:44:50.748Z] 0:07.70 self._resultForDoCleanups = None
[task 2020-10-10T09:44:50.749Z] 0:07.70 try:
[task 2020-10-10T09:44:50.749Z] 0:07.70 testMethod = getattr(self, methodName)
[task 2020-10-10T09:44:50.749Z] 0:07.70 except AttributeError:
[task 2020-10-10T09:44:50.749Z] 0:07.70 raise ValueError("no such test method in %s: %s" %
[task 2020-10-10T09:44:50.749Z] 0:07.70 > (self.class, methodName))
[task 2020-10-10T09:44:50.749Z] 0:07.70 E ValueError: no such test method in <class 'mach.test.common.TestBase'>: runTest
[task 2020-10-10T09:44:50.749Z] 0:07.70
[task 2020-10-10T09:44:50.749Z] 0:07.70 /usr/lib/python2.7/unittest/case.py:189: ValueError
[task 2020-10-10T09:44:50.749Z] 0:07.70 _________ ERROR at setup of test_generate_mach_completion_script[bash] _________

:ahal, this seems to be caused by Bug 1519990.
Could you take a look, please?
Thank you.

Comment 1

[Intermittent Failures Robot]

9 failures in 4130 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6
• try: 3

Platform breakdown:

• macosx1014-64: 3
• windows10-64: 3
• linux1804-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1670385&startday=2020-10-05&endday=2020-10-11&tree=all

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1519990

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

oh, I just narrowed the bug down and then found it was just assigned this morning!

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mach%2Cosx&tochange=93a35f9c67398cb9c85aa4941ebf100a1925435a&fromchange=59d7cd2a604c7fb3f21f1c90169d957a869f4ffb

happy to review or test a fix.

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1670385 - [mach] Move 'TestBase._run_mach' to a pytest fixture, r?#firefox-build-system-reviewers

I accidentally broke the 'mach' unittests on Python 2 due to some difference in the unittest
module. Rather than poking into 'unittest', this patch moves us closer to the pytest format
while also fixing the issue.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a7006c24e69
[mach] Move 'TestBase._run_mach' to a pytest fixture, r=firefox-build-system-reviewers,rstewart

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7a7006c24e69

Comment 8

[Intermittent Failures Robot]

4 failures in 3694 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 4

Platform breakdown:

• linux1804-64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1670385&startday=2020-10-12&endday=2020-10-18&tree=all