Closed Bug 1670385 Opened 4 years ago Closed 4 years ago

Permafailing tier 2 [mach] ValueError: no such test method in <class 'mach.test.common.TestBase'>: runTest on mach/test/test_commands.py

Categories

(Firefox Build System :: Mach Core, defect)

defect

Tracking

(firefox-esr78 unaffected, firefox81 unaffected, firefox82 unaffected, firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 --- fixed

People

(Reporter: nataliaCs, Assigned: ahal)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&group_state=expanded&selectedTaskRun=BueSlQmtTAax_clekpvKTQ.0&searchStr=mach&revision=5abe1c13c7b37cdf5b03d3063530560981a3d253

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318249397&repo=mozilla-central&lineNumber=134

[task 2020-10-10T09:44:50.747Z] 0:07.70 ==================================== ERRORS ====================================
[task 2020-10-10T09:44:50.748Z] 0:07.70 ____________________ ERROR at setup of test_mach_completion ____________________
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 @pytest.fixture
[task 2020-10-10T09:44:50.748Z] 0:07.70 def run_mach():
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 > tester = TestBase()
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 python/mach/mach/test/test_commands.py:30:
[task 2020-10-10T09:44:50.748Z] 0:07.70 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 self = <mach.test.common.TestBase testMethod=runTest>, methodName = 'runTest'
[task 2020-10-10T09:44:50.748Z] 0:07.70
[task 2020-10-10T09:44:50.748Z] 0:07.70 def init(self, methodName='runTest'):
[task 2020-10-10T09:44:50.748Z] 0:07.70 """Create an instance of the class that will use the named test
[task 2020-10-10T09:44:50.748Z] 0:07.70 method when executed. Raises a ValueError if the instance does
[task 2020-10-10T09:44:50.748Z] 0:07.70 not have a method with the specified name.
[task 2020-10-10T09:44:50.748Z] 0:07.70 """
[task 2020-10-10T09:44:50.748Z] 0:07.70 self._testMethodName = methodName
[task 2020-10-10T09:44:50.748Z] 0:07.70 self._resultForDoCleanups = None
[task 2020-10-10T09:44:50.749Z] 0:07.70 try:
[task 2020-10-10T09:44:50.749Z] 0:07.70 testMethod = getattr(self, methodName)
[task 2020-10-10T09:44:50.749Z] 0:07.70 except AttributeError:
[task 2020-10-10T09:44:50.749Z] 0:07.70 raise ValueError("no such test method in %s: %s" %
[task 2020-10-10T09:44:50.749Z] 0:07.70 > (self.class, methodName))
[task 2020-10-10T09:44:50.749Z] 0:07.70 E ValueError: no such test method in <class 'mach.test.common.TestBase'>: runTest
[task 2020-10-10T09:44:50.749Z] 0:07.70
[task 2020-10-10T09:44:50.749Z] 0:07.70 /usr/lib/python2.7/unittest/case.py:189: ValueError
[task 2020-10-10T09:44:50.749Z] 0:07.70 _________ ERROR at setup of test_generate_mach_completion_script[bash] _________

:ahal, this seems to be caused by Bug 1519990.
Could you take a look, please?
Thank you.

Flags: needinfo?(ahal)

Set release status flags based on info from the regressing bug 1519990

Assignee: nobody → ahal
Status: NEW → ASSIGNED
Flags: needinfo?(ahal)

I accidentally broke the 'mach' unittests on Python 2 due to some difference in the unittest
module. Rather than poking into 'unittest', this patch moves us closer to the pytest format
while also fixing the issue.

Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a7006c24e69
[mach] Move 'TestBase._run_mach' to a pytest fixture, r=firefox-build-system-reviewers,rstewart
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: