1670508 - Firefox with profile in ram disk after update to 79, forcing users from local to sync storage for add-on and caused add-on fail to load data .

Status: REOPENED

(WebExtensions :: Storage, defect, P5)

Description

[agwegame]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1. Install Firefox 78.
2. Open profile manager.
3. Create a new profile and set to Ram disk and Launch and don't sign in Firefox account.
4. Install this add-on https://addons.mozilla.org/en-US/firefox/addon/videospeed/
5. Take a look of setting of video speed controller and confirm that all setting appear.
   (You can also try to play a YouTube video and test the add-on functions work fine.)
6. Update Firefox to 79 or higher
7. Open installed add-on (video speed controller) setting
8. Try to set to default and save and reload the setting page
9. Try to set any value and save and reload
   (You can also try to play a YouTube video and observer the add-on functions are not working)

Actual results:

Add-on failed to load data after update to 79.
https://user-images.githubusercontent.com/68129013/95672165-2a427180-0bd1-11eb-91b2-c09eecce07ae.jpg
https://user-images.githubusercontent.com/68129013/95672173-2d3d6200-0bd1-11eb-8950-f3d07c54026c.jpg

Here is the similar result in another add-on from me
Please take a look and see how they fix this
https://github.com/darkreader/darkreader/issues/3297

Expected results:

Add-on successes to load data

Comment 1

[agwegame]

What happen after update to 79
https://user-images.githubusercontent.com/68129013/95672171-2ca4cb80-0bd1-11eb-9b56-e7064912b864.jpg

Comment 2

[Daniel Bodea [:danibodea]]

Are you using Release versions of Firefox (78 and 79) to reproduce this issue?

Furthermore, how do you "set to Ram disk"? what do you mean by that?

Comment 3

[Daniel Bodea [:danibodea]]

Andrew, did you reproduce this bug? Can you help clarify the steps to reproduce?

Comment 4

[agwegame]

(In reply to Bodea Daniel [:danibodea] from comment #2)

Are you using Release versions of Firefox (78 and 79) to reproduce this issue?

Furthermore, how do you "set to Ram disk"? what do you mean by that?

When 79 launched, I update from 78.0.2, and found out add-ons not working, then I sought help from dark reader git-hub because I though these was add-on problem and I rolled back to 78.0.2 to wait any fix till now, I am using 78.3.1esr, those add-ons work fine on ram disk.
Here is where I download the 78.0.2
https://download-installer.cdn.mozilla.net/pub/firefox/releases/78.0.2/win64/en-US/Firefox%20Setup%2078.0.2.exe
And I updated to 79 which is the latest version at that point to test if add-ons work.
You can download and install 79 here to reproduce this step, but the key point is after 79, add-ons is not working, even 81, so you can just straight update to 81 from 78.0.2, it still show same result.
https://download-installer.cdn.mozilla.net/pub/firefox/releases/79.0/win64/en-US/Firefox%20Setup%2079.0.exe

Here is how to "set to Ram disk"
take a look these steps.
https://github.com/darkreader/darkreader/issues/3297#issuecomment-667629441

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

I have no idea if this is valid, but it seems the report is that browser.storage doesn't work after upgrade when the profile is on a ram disk. ram disks are ephemeral, so I don't understand the report at all, but this component seems more appropriate.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Would you mind to provide us the steps for creating the ramdisk?

Comment 8

[Tomislav Jovanovic :zombie]

Closing as incomplete, feel free to reopen when you have STR.

Comment 9

[agwegame]

(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #7)

Would you mind to provide us the steps for creating the ramdisk?

Sorry that late to reply because I was using 78 esr to bypass the problem and forgot this report.
However 78 esr is no longer update and next esr version is 91, so this is time to face it.

Here is my using ram disk software and setting:
Software: ImDisk toolkit
Link:https://sourceforge.net/projects/imdisk-toolkit/
I used the default installation.
Then there should be three icon on desktop.
Click RamDisk Configuration.
My Setting:
Size 5GB
check Allocate Memory Dynamically
check Launch at Windows Startup
check Create TEMP Folder
Then go to Set TEMP Variables...
Select Use a Junction(recommended)
from: C:\ProgramData\TEMP
to R:\TEMP

Since using junction cause Firefox can't choose Open when a download window popup.
related link:https://sourceforge.net/p/imdisk-toolkit/discussion/general/thread/8ecbbcbf8d/
So a .bat file is suggested

set TMP=R:\Temp
set TEMP=R:\Temp
start "" /b "%ProgramW6432%\Mozilla Firefox\firefox.exe" %*

%* is added for open firefox with argumnets

And then Create a new profile in ram disk and install the Video Speed Controller addon
link:https://addons.mozilla.org/en-US/firefox/addon/videospeed/
Next go to setting of the addon
Should obverse all field is blank
and
storage is undefined will be logged if you debug and inspect the addon.

Comment 10

[Alex Cornestean]

Hello,

I believe I reproduced the issue on the latest Release under Windows 10 x64.

First I set up a Ram Disk as per the instructions from Comment 9, launched Firefox 78 with a new profile created on the Ram Disk and installed the extension.
I saw no errors in the debug console of the add-on and the add-on settings page had no blank fields. (see attached screenshot78).

Afterwards, I’ve updated the browser to the latest version. Checked the debug console and the settings page once more. “storage is undefined” was logged to console and the settings page had all blank fields. (see attached screenshot94 and console94).

Since I think I reproduced the issue, I wanted to perform a bisection to find the regressor but ran into the problem of making mozregression create profiles on the Ram Disk. I’m not sure how to force mozregression to do that. Tried several things but none worked.

Comment 11

[Alex Cornestean]

Attachment: screenshot78.png

Comment 12

[Alex Cornestean]

Attachment: screenshot94.png

Comment 13

[Alex Cornestean]

Attachment: console94.png

Comment 15

[Rob Wu [:robwu]]

Does this sound related / similar to bug 1733101?

Comment 16

[tophf]

For me the annoying part is that I can't load temporary extensions from my RAM drive (ImDisk) which I use for all temporary stuff.

Bisected to Firefox 75: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=388d81ed93fa640f91d155f36254667c734157cf&tochange=36f95aeb4c77f7cf3b3366583008cd6e4b6b1dba

Judging by the displayed error it's https://hg.mozilla.org/mozilla-central/rev/e4e70a229f5e71859aecd7299dbcfd30f03fc9ac