1670515 - Assertion in VideoFrameConverter

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Seen on try: https://treeherder.mozilla.org/logviewer.html#?job_id=318315865&repo=try when we disable the h264 HW decoder.

Assertion failure: false (MOZ_ASSERT_UNREACHABLE: YUV format conversion not implemented), at /builds/worker/checkouts/gecko/dom/media/ImageToI420.cpp:109

The code in ImageUtils make assumptions that the Cb plane is found before the Cr plane in memory, with IMF images apparently this isn't the case, leading to the failure.

https://searchfox.org/mozilla-central/rev/c2e3ac11be4837718c2604e58085fbc8252b69dd/dom/canvas/ImageUtils.cpp#54-73

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1670515 - Don't assume memory position of planes. r?mattwoodrow

The Cb plane doesn't have to be located after the Cr plane in memory, there are referred via pointers, all it matters is that they don't overlap.

Note that none of those extra tests serve much purpose, none of your code can generated a 3 planes YUV image where the skip value wouldn't be 0.

However, not knowing how that code is called and if it's still in use today, taking the safer approach of just fixing the existing test.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d291752989c
Don't assume memory position of planes. r=mattwoodrow

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6d291752989c