1670541 - Line break inside embedded object breaks line offsets in parent

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

STR (with the NVDA screen reader):

1. Open this test case:
   data:text/html,<button>before</button><div contenteditable>a <a href="https://mozilla.org/">b<br>c</a> d
2. Tab to the contenteditable.
3. Press control+home.
   • Observe: NVDA says "a"
4. press down arrow.
   • Expected: NVDA should say "link c d"
   • Actual: NVDA says "blank"

This happens because if you query the line at offset 2 (the embedded object) on the div, Gecko reports (0, 2, "a "). It should report (0, 5, "a * d"), where * is an embedded object character.

Note that this also happens with word wrap; i.e. it doesn't have to be a forced line break (which is probably less common inside a link). Example:
data:text/html,<button>before</button><div contenteditable style="width: 20px; word-wrap: break-word;">a <a href="https://mozilla.org/">b c</a> d

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1670541 - Return the parent line end offset if an embedded character contains a line break, r?jamie!

If the offset for an embedded character is queried, and it is an inline element, such as a link, and it contains a line break, return the full parent line.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5893300d26cb
Return the parent line end offset if an embedded character  contains a line break, r=Jamie

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5893300d26cb