16706 - [DOGFOOD] [BLOCKER] HTML that is inserted into the editor with InsertAsSource() dissapears after first keystroke

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[rhp (gone)]

For mail/news, we use the InsertAsSource() calls to insert the HTML signature
for a new HTML message compose window. After this is done, everything appears
correct, but when you type the first keystroke, the contents that you inserted
vanish.

Comment 1

[Akkana Peck]

Accepting and would like to fix for M11, but right now I can't get signature
insertion to work for me at all due to bug 16708; marking a dependency on that
bug.

Comment 2

[Akkana Peck]

Alec helped me get signatures working.  The problem here is that we start with
an empty document containing only the editor bogus node; when the html gets
inserted, it gets inserted *inside* the bogus node, so anything that's typed
subsequently causes it all to disappear.

Cc'ing Joe, with whom I'll probably have to work to figure out how the bogus
node works and how to work around it for InsertHTML.

Comment 3

[Akkana Peck]

Attachment: Preliminary patch

Comment 4

[Akkana Peck]

I've attached a patch which solves the problem.  I'm not sure it's the best
permanent solution -- it has InsertHTML calling into the rules code only in the
case where the document is empty, and calling in with kInsertElement even though
it's about to delete something before it does the insert.  But it does cure the
problem and makes both signatures and quoting work correctly with Rich's mail
patches.

It certainly doesn't make things any worse; if someone will review this, I can
go ahead and check it in, and hopefully Joe can advise on whether this is the
right thing to do in the long run.  Oh, ignore the printf in the patch -- I
noticed and removed that right after attaching the patch, and it didn't seem
worth attaching another patch just for that.

Comment 5

[rhp (gone)]

For what it's worth, the patch looks fine to me. But I'm not very familiar with
that code.

- rhp

Comment 6

[Akkana Peck]

Checked in the fix as approved by Joe (a slightly different one than the one
attached here).

Comment 7

[rhp (gone)]

Yes, this is working fine now. Thanks!

- rhp

Comment 8

[rubydoo123]

linking to PDT+ tracking bug 12658