Closed
Bug 1670686
Opened 4 years ago
Closed 4 years ago
Update to clang 11.0.0 final release
Categories
(Firefox Build System :: Toolchains, enhancement)
Firefox Build System
Toolchains
Tracking
(firefox83 fixed)
RESOLVED
FIXED
83 Branch
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta-
|
Details | Review |
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de0d801e6fb8
Update to clang 11.0.0 final release r=firefox-build-system-reviewers,andi,rstewart
Comment 3•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Comment on attachment 9181034 [details]
Update to clang 11.0.0 final release
@jcristau: This uplift is not required but I wanted to see what you think. I'm a little bit uncomfortable changing a compiler so close to release. There's an argument that we've put more testing on the current RC3 even if it is not final. On the other hand, maybe there's some latent bug that has been fixed between RC3 and final. It's hard to say without a crystal ball which is less risky. Since you deal with uplifts much more frequently, I figure you have a more reliable sense about this topic than me.
Beta/Release Uplift Approval Request
- User impact if declined: Inconsistent compiler versus nightly + incomplete release candidate (== probably harmless but I don't know)
- Is this code covered by automated tests?: Unknown
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): See note above
- String changes made/needed: none
Attachment #9181034 -
Flags: approval-mozilla-beta?
Comment 5•4 years ago
|
||
Comment on attachment 9181034 [details]
Update to clang 11.0.0 final release
we've already built a release candidate for 82, let's not take that risk now
Attachment #9181034 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in
before you can comment on or make changes to this bug.
Description
•