1670785 - Fix ASRouter devtools force attribution write on mac

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

With https://bugzilla.mozilla.org/show_bug.cgi?id=1525076 fix, we have changed writing attribution on mac. Scope of the bug is to fix devtools FORCE_ATTRIBUTION handling on mac

https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/ASRouter.jsm#1742

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1670785 - Fix ASRouter devtools force attribution on MacOS

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f1be8d41b21
Fix ASRouter devtools force attribution on MacOS r=andreio

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f1be8d41b21

Comment 4

[Nick Alexander :nalexander [he/him]]

Sorry to break this for you, folks -- glad you got it fixed.

Comment 5

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using the latest Firefox Release 108.0.1 (build ID: 20221215175817) on macOS 12.6 following the next steps:

• Set "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref on "true".
• Navigated to "about:newtab#asrouter" page and clicked the "Targeting" section from the left-hand side of the page.
• Scrolled down to the "Attribution Parameters" section and clicked the "Force Attribution" button after setting the values for an addon.
  By navigating to the "about:welcome" page, I noticed the RTAMO flow being displayed.

Comment 6

[Punam Dahiya [:pdahiya]]

NI @avarro to help confirm Mac Attribution getting set on latest MacOS. My understanding attribution is broken with MacOS Monterey as seen in Bug 1784121. Thanks

Comment 7

[Alice Varro [avarro], Ecosystem QA]

Hi Punam!
I've verified again the Force Attribution set on macOS 12.6 Monterey on the latest versions of Firefox Nightly, Beta and Release and I can confirm now that the attribution is broken on this macOS version.
The steps for verifying this are the follwoing:

• Created a new profile.
• Opened Chrome browser and navigated to addons.mozilla.org page, chose uBlock Origin addon and downloaded the Firefox 108.0.1 Release version.
• Opened the previously downloaded Firefox version with the profile created.
• Navigated to the "about:config" page and set the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref on "true".
• Navigated to "about:newtab#asrouter" page and clicked the "Targeting" section.
• Clicked the "Force Attribution" button after setting the "Medium", "Campaign" and "Content" values for an addon. (I used uBlock Origin, Tomato Clock and FoxClocks)
• Going to the "about:welcome" page I noticed that there is no RTAMO flow being displayed.
  The same steps I followed for Firefox Nightly and Beta, the only difference is that I downloaded those versions from ftp.mozilla.org page.
  Going to the "about:support" page, clicking the "Show in Finder" from "Update Folder" section I noticed that the macAttributionData file it's empty, has zero bytes.