1670808 - Right-clicking the back button doesn't show the previous pages drop-down menu after new tab is opened

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Lyubomir [:mystiquewolf]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

1. Open new tab
2. Enter some text in the address bar that is of some past-visited website title
3. Click the match to load the page
4. Right-click the back button near the address bar

Actual results:

Right-clicking the back button doesn't open the previous sites dropdown menu

Expected results:

Right-clicking the back button should open the previous sites dropdown menu.

Comment 1

[Lyubomir [:mystiquewolf]]

Attachment: screencast

Comment 2

[Lyubomir [:mystiquewolf]]

Attachment: troubleshooting info

Comment 3

[Lyubomir [:mystiquewolf]]

Screencast: https://youtu.be/gYFPuR-mp2k

Comment 4

[Andrei Purice]

Hey Lyubomir,
I tried reproducing this issue on the latest Nightly 83.0a1 (2020-10-16), beta 82.0 and release 81.0.2 with different links and even the one in your video and when I right click the back button there's the page title and new tab present. I also see you have some extensions so I can suggest trying a few things.

Can you test the issue while in Safe Mode? You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .
If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Comment 5

[Lyubomir [:mystiquewolf]]

I have fission.autostart enabled. When i disable it, the issue goes away. Also, when i disable extensions with Fission enabled, the issue again goes away. Though i am not sure if Entering safe mode doesn't disable Fission on its own, because Fission is now a setting in preferences.

Comment 6

[Andrei Purice]

Setting a component for this issue in order to get the dev team involved.
If you feel it's an incorrect one please feel free to change it to a more appropriate one.

Comment 7

[Cameron McCormack (:heycam)]

Moving this to DOM: Navigation due to comment 5. Maybe there's a bad interaction between one of your extensions and Fission?

Comment 8

[Nika Layzell [:nika] (ni? for response)]

(In reply to Lyubomir from comment #5)

I have fission.autostart enabled. When i disable it, the issue goes away. Also, when i disable extensions with Fission enabled, the issue again goes away. Though i am not sure if Entering safe mode doesn't disable Fission on its own, because Fission is now a setting in preferences.

Entering safe mode does disable Fission as well as disabling extensions. It's likely that this is caused by some raciness with SessionStore + Fission.

Comment 9

[Nika Layzell [:nika] (ni? for response)]

I wasn't able to reproduce this issue with Fission enabled anymore. Lyubomir, would you be able to check if this issue still reproduces for you? We've made a lot of changes to our fission history logic in the last 2 months, and may have fixed the issue.

Comment 10

[Lyubomir [:mystiquewolf]]

I'm sorry, i've completely reinstalled the OS with KDE and i am currently on stable Firefox. I cannot afford any time to test due to personal issues.

Comment 11

[Neha Kochar [:neha]]

I'm able to repro this but not in its entirety. Following the steps in the description, the first right click on the back button doesn't do anything, but the next right click does correctly display the previously visited page list. I'm using Mac and latest Nightly with Fission.

Comment 12

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

This seems to be frontend issue.
https://searchfox.org/mozilla-central/rev/b9384b091e901b3283ce24b6610e80699d79fd06/browser/base/content/browser.js#4444 opens the menu for long-left-press and the popupshowing event creates content.
But same thing doesn't happen for contextmenu (right click).
So the menu does actually contain the entries, but for contextmenu case it isn't opened.

https://searchfox.org/mozilla-central/rev/b9384b091e901b3283ce24b6610e80699d79fd06/browser/base/content/browser.js#4439-4443 has possibly related comment.

Comment 13

[Neha Kochar [:neha]]

Neil, can you work on this from the frontend side?

Comment 14

[Neil Deakin]

Attachment: Bug 1670808, if session history in parent is available, use that to get the items for the back forward menu instead. Otherwise, don't cancel showing the context menu if only one history item is available, r=gijs

FillHistoryMenu was returning early and preventing the context menu from opening when there is only one history item. For long-presses, the menu typically doesn't open until after the updateSessionHistory callback was finished so the menu shows properly, but context menus have no delay. However, when browsingContext.sessionHistory is available, we can get the history without callbacks.

Also, combine the two similar session history tests into one more complete test.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c840a269bd87
if session history in parent is available, use that to get the items for the back forward menu instead. Otherwise, don't cancel showing the context menu if only one history item is available, r=Gijs

Comment 16

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c840a269bd87