1670824 - --chaos should not be type=int

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task)

Description

[Andrew McCreight [:mccr8]]

The --chaos command line option is defined in testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py with type=int. Later, this value is used to set an environment variable: env["MOZ_CHAOSMODE"] = str(self.chaos_mode_flags).

This means that the command line option has to be a base 10 integer, and the env var will be set to a base 10 integer. However, this value is supposed to be a hex value: https://searchfox.org/mozilla-central/rev/d25eb00ab4e90cc0130cd18f303a04cc2a2f8409/toolkit/xre/nsAppRunner.cpp#3458-3466

If the env var fails to parse as a hex value, then it is treated as ChaosFeature::Any, so this is probably okay for the most common use case, but you can't set it to any other value, like 0xfb, which seems to be the default in reftests and mochitests.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1670824 - Parse --chaos argument as hex,

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ed95ae6403a
Parse --chaos argument as hex, r=mccr8

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37028 for changes under testing/web-platform/tests

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9ed95ae6403a

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot